Summary:IMM: Dumpimg resource utilization data for IMMsv [#35]
Review request for Trac Ticket(s): 35
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es): default(4.5)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 376357a7026d631179629f8051560d45d3170861
Author: Neelakanta Reddy<reddy.neelaka...@oracle.com>
Date: Mon, 14 Jul 2014 14:46:53 +0530
IMM: Dumpimg resource utilization data for IMMsv [#35] The enhancement
dumps
the IMMsv resource utilization data using IMM Admin Operation. The IMM
AdminOperation must be directed to immsv object
opensafImm=opensafImm,safApp=safImmService.
Presently two types of operationNames for dumping resource utilization
is
supported:
display -- returns the terse output for the requested resource. The
number
of requested resource will be returned. The supported resource are
implementers, adminowners, ccbhandles and searchhandels.
Eg:
immadm -O display -p resource:SA_STRING_T:implementers
opensafImm=opensafImm,safApp=safImmService
The output is the number of implementers present: Name
Type Value(s)
========================================================================
count SA_INT64_T 9 (0x9)
displayverbose -- returns the verbose output for the requested
resource. The
verbose output is supported for the resources implementers and
adminowners.
If the number of resource is greater than 127 then the verbose output is
displayed to syslog.
Eg: immadm -O displayverbose -p resource:SA_STRING_T:implementers
opensafImm=opensafImm,safApp=safImmService [using admin-owner:
'safImmService'] Object: opensafImm=opensafImm,safApp=safImmService Name
Type Value(s)
========================================================================
safLogService SA_INT64_T 131343
(0x2010f) safClmService SA_INT64_T
131343 (0x2010f) safAmfService
SA_INT64_T 131343 (0x2010f) MsgQueueService131343
SA_INT64_T 131343 (0x2010f) safMsgGrpService
SA_INT64_T 131343 (0x2010f) safCheckPointService
SA_INT64_T 131343 (0x2010f) safEvtService
SA_INT64_T 131343 (0x2010f) safLckService
SA_INT64_T 131343 (0x2010f) safSmfService
SA_INT64_T 131343 (0x2010f)
If the operationName display-help is used, the return parameters will
have
presently supported resources for dumping resource utilization data.
Eg: immadm -O display-help opensafImm=opensafImm,safApp=safImmService
[using admin-owner: 'safImmService'] Object:
opensafImm=opensafImm,safApp=safImmService Name
Type Value(s)
========================================================================
supportedResources SA_STRING_T implementers
supportedResources SA_STRING_T adminowners
supportedResources SA_STRING_T ccbhandles
supportedResources SA_STRING_T
searchhandels
error-string is returned. if any of the dispaly operations fails.
immadm is modified for displaying the returned parameters when dumping
of
resource utilization is supported .
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 279
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
osaf/services/saf/immsv/immnd/ImmModel.hh | 10 ++-
osaf/services/saf/immsv/immnd/immnd_evt.c | 43 ++++++++++++-
osaf/services/saf/immsv/immnd/immnd_init.h | 6 +-
osaf/tools/safimm/immadm/imm_admin.c | 13 ++-
5 files changed, 333 insertions(+), 18 deletions(-)
Testing Commands:
-----------------
Test all the supported dumping operations on supported resources.
1. display
2. displayverbose
3. dispaly-help
Testing, Expected Results:
--------------------------
ALl supported dumping operations must dump the IMM resource utilization data.
Conditions of Submission:
-------------------------
Ack from AndersBj
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck®
Code Sight™ - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
