Summary: amfd : use OUT_OF_SERVICE as probableCause in alarm notifications [#363] Review request for Trac Ticket(s): <<IF ANY LIST THE #>> Peer Reviewer(s): AMF contributors Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 63f1d22fa7d236bb083693f0be61872c054c3e88 Author: [email protected] Date: Thu, 17 Jul 2014 15:09:59 +0530 amfd : use OUT_OF_SERVICE as probableCause in alarm notifications [#363] At present AMF uses SA_NTF_SOFTWARE_ERROR as proable cause while reporting alarms. This patch modifies it to SA_NTF_OUT_OF_SERVICE as it seems more approriate as per ticket description. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/comp.cc | 4 ++-- osaf/services/saf/amf/amfd/ntf.cc | 14 +++++++------- osaf/services/saf/amf/amfd/si.cc | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) Testing Commands: ----------------- Tested AMF enabled application. Testing, Expected Results: -------------------------- sample notification: eventType = SA_NTF_ALARM_PROCESSING notificationObject = "safSi=AmfDemo2,safApp=AmfDemo1" notifyingObject = "safApp=safAmfService" notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.5 (0x5) additionalText = "SI designated by safSi=AmfDemo2,safApp=AmfDemo1 has no current active assignments to any SU" probableCause = SA_NTF_OUT_OF_SERVICE perceivedSeverity = SA_NTF_SEVERITY_MAJOR eventType = SA_NTF_ALARM_PROCESSING notificationObject = "safComp=AmfDemo4,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1" notifyingObject = "safApp=safAmfService" notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.2 (0x2) additionalText = "Instantiation of Component safComp=AmfDemo4,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1 failed" - additionalInfo: 0 - infoId = 1 infoType = 10 infoValue = "safAmfNode=SC-1,safAmfCluster=myAmfCluster" probableCause = SA_NTF_OUT_OF_SERVICE perceivedSeverity = SA_NTF_SEVERITY_MAJOR Conditions of Submission: ------------------------- Ack from anyone. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
