Hi zoran, Reviewed and tested the patch. Ack.
/Neel. On Thursday 17 July 2014 03:58 PM, Zoran Milinkovic wrote: > Summary: imm: add support for configurable OI callback timeout [#16] > Review request for Trac Ticket(s): 16 > Peer Reviewer(s): Neelakanta, Anders > Pull request to: Zoran > Affected branch(es): default(4.5) > Development branch: default(4.5) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset c51e1d7df36e565801f8626d98e5fc3f93755237 > Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> > Date: Thu, 17 Jul 2014 12:18:28 +0200 > > imm: add support for configurable OI callback timeout [#16] > > When an implementer is set, the configurable timeout is sent to IMM > service. > The configurable timeout is used for calculating timeouts for OI > callbacks > and waiting on search replies from RTA update callback. > > changeset 2fac531821e4179bdf826431f4d516522125da90 > Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> > Date: Thu, 17 Jul 2014 12:21:27 +0200 > > imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout [#16] > > IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service > using implementer set operations. > > changeset 7cfcaa451c6d2939a99ddd0d971e9cb2d8804b94 > Author: Zoran Milinkovic <zoran.milinko...@ericsson.com> > Date: Thu, 17 Jul 2014 12:23:04 +0200 > > immtests: add test cases for OI callback timeout [#16] > > Test cases cover OI callback timeout and timeout on searching for an > object > with RTA > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/imma/imma_cb.h | 1 + > osaf/libs/agents/saf/imma/imma_oi_api.c | 22 +++++++++++- > osaf/libs/common/immsv/immsv_evt.c | 54 > +++++++++++++++++++++++++++- > osaf/libs/common/immsv/include/immsv_evt.h | 4 ++ > osaf/libs/common/immsv/include/immsv_evt_model.h | 1 + > osaf/services/saf/immsv/immd/immd_evt.c | 9 ++++- > osaf/services/saf/immsv/immnd/ImmModel.cc | 101 > +++++++++++++++++++++++++++++++++++++--------------- > osaf/services/saf/immsv/immnd/ImmModel.hh | 6 ++- > osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 24 ++++------- > osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 19 +++------ > osaf/services/saf/immsv/immnd/immnd_evt.c | 46 > ++++++++++++++++++++--- > osaf/services/saf/immsv/immnd/immnd_init.h | 9 +++- > tests/immsv/implementer/test_cleanup.c | 1 + > tests/immsv/implementer/test_saImmOiImplementerSet.c | 336 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 14 files changed, 559 insertions(+), 74 deletions(-) > > > Testing Commands: > ----------------- > immoitest > > > Testing, Expected Results: > -------------------------- > immoitest must pass all tests > > > Conditions of Submission: > ------------------------- > Ack from Neelakanta and Anders > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
