Summary: amfd: return FAILED_OP to RtAttrUpdateCallbackT if RtObjectUpdate_2
fails [#426]
Review request for Trac Ticket(s): #426
Peer Reviewer(s): Anders Bj, Hans F, Hans N, Praveen
Pull request to:
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset d56b9f9b93f4748472cb806a0403377b44d54752
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Thu, 31 Jul 2014 13:41:10 +0530
amfd: return FAILED_OP to RtAttrUpdateCallbackT if RtObjectUpdate_2
fails
[#426] As of now, if saImmOiRtObjectUpdate_2 in context of
SaImmOiRtAttrUpdateCallbackT, amf still returns OK to imm. Amf should
return
FAILED_OP to SaImmOiRtAttrUpdateCallbackT in case, it couldn't update
the
attributes successfully. This case is hitting when object is being
deleted
and Amf is trying to update the some of the attributes of that object to
imm. So, if saImmOiRtObjectUpdate_2 fails, then Amf need to abort to
update
the other attributes and immediately return FAILED_OP to imm. Anyway the
object is getting deleted.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/compcstype.cc | 13 ++++++++++---
osaf/services/saf/amf/amfd/imm.cc | 3 ++-
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
osaf/services/saf/amf/amfd/su.cc | 18 ++++++++++++------
4 files changed, 25 insertions(+), 11 deletions(-)
Testing Commands:
-----------------
Start controller, upload the configuration of demo(immcfg -f
/tmp/AppConfig-2N.xml)
Keep 4 sec sleep in compcstype_ccb_completed_cb.
1. Run the below commands one after the other from two terminals
immcfg -d
"safSupportedCsType=safVersion=1\,safCSType=AmfDemo1,safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1"
immlist
"safSupportedCsType=safVersion=1\,safCSType=AmfDemo1,safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1"
2. Run the below commands one after the other from two terminals
immcfg -d safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1;
immlist safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1;
Testing, Expected Results:
--------------------------
1. Check the trace, Amfd returns FAILED_OP to imm as below:
Jul 31 14:05:07.905205 osafamfd [12193:imm.cc:0701] << rt_attr_update_cb: 21
2. Check the trace, Amfd returns FAILED_OP to imm as below:
Jul 31 14:05:07.905205 osafamfd [12193:imm.cc:0701] << rt_attr_update_cb: 21
Conditions of Submission:
-------------------------
Ack from peer maintainers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
