Hi Hans, Regarding #1, are you going to publish it again?
> > > 2. Ideally, if saAmfCompCSISetCallbackTimeout is set, changing > saAmfCtDefCallbackTimeout should not be affecting > > > saAmfCompCSISetCallbackTimeout. So is true for other Timeouts attributes. > > [Hans] as I understand this is taken care of in avnd_comptype_oper_req() I didn't find it in the patch. As I had suggested before as below. The patch need change. > > Regarding #2: I agree with your interpretation. So, patch needs change. > > Amfnd should check whether saAmfCompCSISetCallbackTimeout has been > > configured and accordingly update the value. > > For example, you can take reference from sgtype > > (saAmfSgtDefAutoRepair_configured) and sg > (saAmfSGAutoRepair_configured). Thanks -Nagu > -----Original Message----- > From: Hans Feldt [mailto:[email protected]] > Sent: 11 August 2014 15:08 > To: [email protected] > Subject: [devel] FW: [PATCH 1 of 1] AMF: support immediate effect when > changing comp-type attributes V2 [#819] > > > > > -----Original Message----- > > From: Hans Feldt > > Sent: den 11 augusti 2014 11:04 > > To: 'Nagendra Kumar'; Hans Nordebäck; Praveen Malviya > > Subject: RE: [PATCH 1 of 1] AMF: support immediate effect when changing > comp-type attributes V2 [#819] > > > > > > > > > -----Original Message----- > > > From: Nagendra Kumar [mailto:[email protected]] > > > Sent: den 18 juli 2014 14:50 > > > To: Hans Nordebäck; Hans Feldt; Praveen Malviya > > > Cc: [email protected] > > > Subject: RE: [PATCH 1 of 1] AMF: support immediate effect when changing > comp-type attributes V2 [#819] > > > > > > 1. Is changing saAmfCtDefCallbackTimeout, scope of this ticket ? > > > The other > attributes remain untouched. > > [Hans] the scope is described in the ticket, support changes to all > > WRITEABLE > attributes. But in some priority order implementation > > wise. To me all the comptype timeouts should be writeable which they were in > V1 of the comptype patch. The v2 patch should be > > ignored. The remaining attributes, argv etc can be dealt with afterwards if > there is time... > > > > > 2. Ideally, if saAmfCompCSISetCallbackTimeout is set, changing > saAmfCtDefCallbackTimeout should not be affecting > > > saAmfCompCSISetCallbackTimeout. So is true for other Timeouts attributes. > > [Hans] as I understand this is taken care of in avnd_comptype_oper_req() > > > > > > > > Thanks > > > -Nagu > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
