Summary: Fix validity check for IMM create/modify stream
Review request for Trac Ticket(s): #448
Peer Reviewer(s): mathi.naic...@oracle.com
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): 4.3, 4.4, 4.5 (devel)
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset d0fe365580f4f8d1920cbdf96f2959ff69726044
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Wed, 13 Aug 2014 13:46:59 +0200
log: Fix validity check for IMM create/modify stream [#448]
Fix incorrect existing validation and add missing validation when a
stream
configuration object is created or modified
changeset f52cc61c547041c10a544432313a01ce4cef1ef4
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Wed, 13 Aug 2014 13:52:28 +0200
log: Fix incorrect test cases in current test suite [#448]
Fix incorrect testing of saLogStreamMaxFileSize.
changeset 1d0a59745106cbf7ed974c7d7946af18be52775f
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Wed, 13 Aug 2014 13:59:23 +0200
log: Add new tests for validation of attributes at create/modify stream
conf
obj [#448]
Add new test suite for testing validation of attributes when creating or
modifying stream configuration object
Complete diffstat:
------------------
osaf/libs/saf/include/saLog.h | 8 +-
osaf/services/saf/logsv/lgs/lgs_imm.c | 806
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
osaf/services/saf/logsv/lgs/lgs_util.c | 2 +-
tests/logsv/tet_LogOiOps.c | 10 +-
4 files changed, 672 insertions(+), 154 deletions(-)
Testing Commands:
-----------------
# logtest
Testing, Expected Results:
--------------------------
All testcases shall pass
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
