Summary:: MDS logging improvements [#520]
Review request for Trac Ticket(s): Mathi/ Hans / Ramesh
Peer Reviewer(s): <<LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE>>
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es):default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 3467ed368450ed099916cfda594ccc6fc59d9130
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 14 Aug 2014 20:20:27 +0530
mds: change mds logging prefix readability [#520] 1) No function change,
only Changed the log prefix :
Previously: <Date> <tipcid/pid>
<log category> |<MDS_MODULE_NAME>:
-----------------------------------------------------------------------------
-------------------------------------------------- Example : Nov 22
11:30:33.409534 <3155214320> NOTIFY |MDTM:
Now Changed to: <Date> <processname[pid] <log
category> <MDS_MODULE_NAME>:
-----------------------------------------------------------------------------
----------------------------------------------------- Example : Aug
14 9:52:29.008845 osafimmd[2807] NOTIFY |MDTM:
2) No function change, only Changed BEGIN MDS LOGGIN header from to
Previously: Nov 22 11:23:21.567504 <5049> NOTIFY |BEGIN MDS LOGGING|
PID=5049|ARCH=0|64bit=0 Now Changed to: Aug 14 9:52:26.068220
osafamfd[2871] NOTIFY |BEGIN MDS LOGGING| PID=[osafamfd[2871]] |
ARCHW=9|64bit=1
changeset 5d9de91650c594c96d17325b83f8a0668f59547e
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 14 Aug 2014 20:21:21 +0530
mds: use ncsmds_svc_names mapping array of ncsmds_svc_id for logging
[#520]
1) difined mds_papi.h mapping
Previously service getting log as SVCid = %d Example : Nov 22
11:30:33.409711 <3155214320> NOTIFY |MDTM: svc up event for SVCid =33,
subscri. by SVCid =33 pwe_id=1
Now service log as svc_id = %s Example : Aug 14 9:52:26.073064
osafamfd[2871] NOTIFY |MDTM: svc up event for svc_id = IMMND(25),
subscri.
by svc_id = IMMA_OI(27) pwe_id=1
changeset 137aec853d88c379b153cd8663bf4404495fe67e
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 14 Aug 2014 20:26:32 +0530
mds: update adest details for log readability [#520] 1) Update once
adest
details in MDS_SUBSCRIPTION_RESULTS_INFO
For now adest will be printed like Adest = <node[1]:osafamfd[2871]> for
local node This is just being level changes still long way to go.....
Example : Aug 14 9:52:26.073064 osafamfd[2871] NOTIFY |MDTM: svc up
event for svc_id = IMMND(25), subscri. by svc_id = IMMA_OI(27) pwe_id=1
Adest = <node[1]:osafamfd[2871]> Aug 14 9:52:28.179722 osafclmd[2852]
NOTIFY |MDTM: svc up event for svc_id = AVND(13), subscri. by svc_id =
CLMS(34) pwe_id=1 Adest = <node[1]:osafclmd[2852]>
changeset 67e32ff43321e2578eb6ecdc30be5d5ef7f2ef44
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 14 Aug 2014 20:31:21 +0530
mds: update logs according for readability [#520]
1 ) <actual log> update with svc_names 2) <actual log> arguments warning
fixes 3) <actual log> update few logs with adest details
Complete diffstat:
------------------
osaf/libs/core/include/mds_papi.h | 6 +
osaf/libs/core/mds/include/mds_core.h | 7 +
osaf/libs/core/mds/include/mds_dt2c.h | 1 +
osaf/libs/core/mds/include/mds_dt_tcp.h | 1 +
osaf/libs/core/mds/mds_c_api.c | 763
++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------
osaf/libs/core/mds/mds_c_db.c | 196 ++++++++++++++++++++++++++-
osaf/libs/core/mds/mds_c_sndrcv.c | 365
+++++++++++++++++++++++++--------------------------
osaf/libs/core/mds/mds_dt_common.c | 48 +++---
osaf/libs/core/mds/mds_dt_tcp.c | 3 +
osaf/libs/core/mds/mds_dt_tipc.c | 73 +++++----
osaf/libs/core/mds/mds_dt_trans.c | 22 +-
osaf/libs/core/mds/mds_log.c | 50 +++++-
osaf/libs/core/mds/mds_main.c | 2 +-
osaf/libs/core/mds/mds_papi.c | 46 ++++++
14 files changed, 886 insertions(+), 697 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
