Ack, code review only. A question related to item 2 in the ticket, instantiation level for NPI is it supported?/Regards HansN On 08/16/14 22:24, [email protected] wrote: > osaf/services/saf/amf/amfd/su.cc | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > > Amfd is setting saAmfSUPreInstantiable to false when NPI comp > is deleted from PI SU. > The logic has been corrected in the fix. > > diff --git a/osaf/services/saf/amf/amfd/su.cc > b/osaf/services/saf/amf/amfd/su.cc > --- a/osaf/services/saf/amf/amfd/su.cc > +++ b/osaf/services/saf/amf/amfd/su.cc > @@ -144,13 +144,14 @@ void AVD_SU::remove_comp(AVD_COMP *comp) > } > > bool old_preinst_value = saAmfSUPreInstantiable; > - bool curr_preinst_value = false; > + bool curr_preinst_value = saAmfSUPreInstantiable; > > // check if preinst possibly is still true > if (comp_is_preinstantiable(comp) == true) { > + curr_preinst_value = false; > i_comp = list_of_comp; > while (i_comp) { > - if (comp_is_preinstantiable(i_comp) == true) { > + if ((comp_is_preinstantiable(i_comp) == true) && > (i_comp != comp)) { > curr_preinst_value = true; > break; > }
------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
