Summary: PLM: ignore MDS events from other nodes Review request for Trac Ticket(s): 1026 Peer Reviewer(s): Mathi, Nagu Pull request to: Mathi Affected branch(es): default, 4.5 Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 80c9d0759c9cc818e8416f1d4fdd9aee60598b6f Author: Alex Jones <[email protected]> Date: Wed, 27 Aug 2014 17:39:09 -0400 plm: ignore MDS events from other nodes [#1026] Aug 27 0:32:50.265452 osafplmd [12007:plms_common_mds.c:0081] ER INVALID MSG FORMAT IN ENC When PLMS receives an MDS event, it does not look at the node from which the event came. When the standby PLMS/PLMS_HRB comes online, the active PLMS gets a MDS_UP for the standby PLMS_HRB, and blindly sets its hrb_dest to it. This is wrong. Solution is to only process MDS events from the local node. Complete diffstat: ------------------ osaf/services/saf/plmsv/plms/plms_proc.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) Testing Commands: ----------------- 1) Bring up an active PLMS with HPI configured 2) Bring up a standby PLMS with HPI configured 3) Do some PLM admin commands that use HPI (e.g. reset an HE) Testing, Expected Results: -------------------------- 1) PLM admin commands should succeed, and internally HPI calls should succeed. Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
