Summary: base: check and truncate(with character T) logtrace messages >= 1024 bytes [#970] Review request for Trac Ticket(s): #970 Peer Reviewer(s): Hans, Ramesh, Neel Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all branches Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services y Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset bcdbb094d86626545c8571aa1e0ee481cfe29ee9 Author: Mathivanan N.P.<[email protected]> Date: Fri, 12 Sep 2014 17:11:57 -0400 base: check and truncate(with character T) logtrace messages >= 1024 bytes [#970] logtrace has locally defined limit of 1024 bytes for the length of message to be printed. It is possible that user of logtrace (TRACE OR LOG_**) can pass messages longer than 1024 bytes. But, logtrace() is not checking for the return value of vsnprintf. vsnprintf would return the number of bytes it could have printed and not the actual bytes printed in scenarios when the length passed to vsnprintf is smaller than the length of the string passed to vsnprintf. The patch makes the effective max length of logtrace messages to 1023 and introduces a turncation character T (like in the log service spec) whenever messages longer than 1023 are passed to TRACE or LOG_**. Complete diffstat: ------------------ osaf/libs/core/common/logtrace.c | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) Testing Commands: ----------------- call TRACE or LOG_** with messages greater than 1023 bytes. Testing, Expected Results: -------------------------- call TRACE or LOG_** with messages greater than 1023 bytes. There should not be any garbage characters. There should be a truncation character T at the end. Conditions of Submission: ------------------------- Ack from Hans, ramesh or neel. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
