Hi AndersBj, Reviewed the patch. Ack.
/Neel. On Friday 19 September 2014 04:29 PM, Anders Bjornerstedt wrote: > Summary: imm: In saImmOiAugmentCcbInitialize goto function end if > om_handle_init fails [#1095] > Review request for Trac Ticket(s): 1095 > Peer Reviewer(s): Neel; Zoran > Pull request to: > Affected branch(es): 4.3: 4.4; 4.5; default(4.6) > Development branch: > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 34cfbb17a1bf2580ca4fac6d2ad77fab8b17cad7 > Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com> > Date: Fri, 19 Sep 2014 12:53:32 +0200 > > imm: In saImmOiAugmentCcbInitialize goto function end if om_handle_init > fails [#1095] > > If mmsv_om_handle_initialize returns non SA_AIS_OK then instead of a > goto to > the 'done' point, we do a goto to 'lock_failed'. The client is not > locked in > this context. > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/imma/imma_oi_api.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Testing Commands: > ----------------- > Problem has not actually been encountered. This is fix is due to a coverity > report. > > > Testing, Expected Results: > -------------------------- > Difficult to actually test effectivenes. > Test of non interfrence should pass. > I have tested with immoitest. > > > Conditions of Submission: > ------------------------- > Ack from Neel > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
