Ack for the series, code review only/Regards HansN
-----Original Message-----
From: Hans Feldt
Sent: den 20 oktober 2014 15:53
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 5] Review Request for pyosaf #751
Summary: fix pylint rating focused on immom Review request for Trac Ticket(s):
751 Peer Reviewer(s): Hans N Pull request to: <<LIST THE PERSON WITH PUSH
ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development
branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 9b1e6a164156671033a713abcb8c5f4adef9848c
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 20 Oct 2014 15:00:21 +0200
pyosaf: remove IMM_A_01_01 from saImm.py [#751]
changeset e46731a816edf96324920a8713e81e92fa062ba2
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 20 Oct 2014 15:35:40 +0200
pyosaf: fix saAis.h pylint rating [#751]
Change wildcard imports Some other minor changes but not mixed
whitespace
changeset e4d6cc60b97a587fa7a9f76f14d23fbee68b175a
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 20 Oct 2014 15:35:42 +0200
pyosaf: fix saEnumConst.py pylint rating [#751]
Change wildcard imports Some other minor changes but not mixed
whitespace
changeset 02ca159805ccfdc6fdd1c1419f318ff3fe3dfae2
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 20 Oct 2014 15:41:16 +0200
pyosaf: fix saImm.h pylint rating [#751]
Change wildcard imports Some other minor changes but not mixed
whitespace
changeset fd2e8d07cf063c064f7c4fa71c1187ed39e198cc
Author: Hans Feldt <hans.fe...@ericsson.com>
Date: Mon, 20 Oct 2014 15:41:17 +0200
pyosaf: fix saImmOm.h pylint rating [#751]
Change wildcard imports Some other minor changes but not mixed
whitespace
Complete diffstat:
------------------
python/pyosaf/saAis.py | 48
+++++++++++++++++++++++++++++++++---------------
python/pyosaf/saEnumConst.py | 53
+++++++++++++++++++++++++++++------------------------
python/pyosaf/saImm.py | 89
+++++++++++++++++++++++------------------------------------------------------------------
python/pyosaf/saImmOm.py | 71
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------
4 files changed, 144 insertions(+), 117 deletions(-)
Testing Commands:
-----------------
$ pylint -d mixed-indentation,invalid-name saAis.py saEnumConst.py saImm.py
saImmOm.py | grep rated
Testing, Expected Results:
--------------------------
rating changed from:
Your code has been rated at -0.08/10 (previous run: -0.08/10, +0.00)
To:
Your code has been rated at 9.50/10 (previous run: -0.08/10, +9.58)
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
