Summary:Imm: Return TRY_AGAIN when slave PRTA timesout and prepare arrives
after the slave timeout [#1211]
Review request for Trac Ticket(s): 1211
Peer Reviewer(s): AndersBj
Affected branch(es): 4.4.x, 4.5.x, default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset c2fa84c711c546a82ae4bc99e73720acafe98f16
Author: Neelakanta Reddy<reddy.neelaka...@oracle.com>
Date: Fri, 21 Nov 2014 18:42:45 +0530
Imm: Return TRY_AGAIN when slave PRTA timesout and prepare arrives
after the
slave timeout [#1211]
problem:
The problem is observed when PRTA update is done. for PRTA updates
PBEA(primary) receives ObjectModifyCallback from local IMMND and PBEB
(slave) receives ModifyCallback from local IMMND in rt_object_update
function parallely.
In this case PBEB received modifycallback and has been timeout after 5
seconds
Nov 13 11:38:14 SLES-64BIT-SLOT2 osafimmpbed: IN PBE slave waiting for
prepare from primary on PRTA update ccb:100000187 Nov 13 11:38:14 SLES-
64BIT-SLOT2 osafimmpbed: NO Slave PBE time-out in waiting on prepare for
PRTA update ccb:100000187 dn:safNode=PL-3,safCluster=myClmCluster
after that PBEA tries to send prepare towards PBEB
Nov 13 11:38:25 SLES-64BIT-SLOT1 osafimmpbed: IN Slave PBE replied with
OK
on attempt to start prepare of ccb:100000187/4294967687 Nov 13 11:38:25
SLES-64BIT-SLOT1 osafimmpbed: IN Starting distributed PBE commit for
PRTA
update Ccb:100000188/4294967688 Nov 13 11:38:25 SLES-64BIT-SLOT1
osafimmnd[3145]: ER PBE PRTAttrs Update continuation missing! invoc:391
Analyses: 1. After PBEB is timeout in Modifycallback slave PBE
ccbutil_deleteCcbData is not deleted, because of these PBEB replied OK
for
prepare from PBEA for the same PRTA update. From this time PBEB
continuously
receives TRY_AGAIN as can be noted in below syslog:
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmpbed: NO Prepare
ccb:100000188/4294967688 received at Pbe slave when Prior Ccb 4294967687
still processing
Nov 13 12:21:47 SLES-64BIT-SLOT2 osafimmpbed: NO Prepare
ccb:10000046b/4294968427 received at Pbe slave when Prior Ccb 4294967687
still processing
2. As explained in above point, PBEB sends OK for prepare from PBEA and
PBEA commits PRTA update and the same update in not present in IMM RAM
and
PBEB, this is because the non SA_AIS_OK reply from PBEB is considered
and
the continuation is removed
Nov 13 11:38:25 SLES-64BIT-SLOT2 osafimmnd[2491]: ER PBE PRTAttrs Update
continuation missing! invoc:391
solution:
1. ObjectModify Callback has been changed (as CreateCallback) to delete
ccbutil_deleteCcbData when PRTA update is timeout.
For 2PBE only PRTA create / PRTA update operation will get parallel
create/modify callback for both PBEA and PBEB.
2. In the pbePrtAttrUpdateContinuation if the return code is SA_AIS_OK
then
check for continuation(similar to pbePrtAttrCreateContinuation)
Complete diffstat:
------------------
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 +++-
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 31
+++++++++----------------------
2 files changed, 12 insertions(+), 23 deletions(-)
Testing Commands:
-----------------
Delay PRTA-update for 5 seconds before sending prepare towards slave. By this
time the slave PBE will timeout
Testing, Expected Results:
--------------------------
If slave PBE receives prepare after slave PBE timeout in callback TRY_AGAIN is
returned.
Conditions of Submission:
-------------------------
Ack from AndersBj
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
