ack, code review only/Thanks HansN
On 11/25/2014 09:59 AM, praveen.malv...@oracle.com wrote:
>   osaf/libs/agents/saf/amfa/ava_api.c |  4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
>
> saAmfResponse() communicates with AMFND synchronously for term callback 
> response.
> When AMFND responds back to agent for the term callback response, the API
> after is processing the message and freeing only message content.
>
> Patch ensures to free allocated memory for response also.
>
> diff --git a/osaf/libs/agents/saf/amfa/ava_api.c 
> b/osaf/libs/agents/saf/amfa/ava_api.c
> --- a/osaf/libs/agents/saf/amfa/ava_api.c
> +++ b/osaf/libs/agents/saf/amfa/ava_api.c
> @@ -1928,7 +1928,9 @@ SaAisErrorT saAmfResponse(SaAmfHandleT h
>       if (hdl_rec)
>               ncshm_give_hdl(hdl);
>   
> -     /* free the contents of the request message */
> +     /* free the contents of the request/response message */
> +     if (msg_rsp)
> +             avsv_nda_ava_msg_free(msg_rsp);
>       avsv_nda_ava_msg_content_free(&msg);
>   
>       TRACE_LEAVE2("rc:%u", rc);


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to