Hi,
IMM documentation is very clear about that:
"The default value is 0 with the intended meaning that long DNs are not
allowed. Any other value has the meaning that long DNs are allowed."
So I think handling the above is missing from current SMF code.
I can send a new patch proposal.
Br,
Robert
-----Original Message-----
From: Bertil Engelholm
Sent: den 5 december 2014 12:35
To: Robert Apanowicz; Ingvar Bergström
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] smf: reading of longDnsAllowed attribute does not
block [#1230]
Maybe also change the check of the values so that it can handle if someone sets
the long DN attribute to something else than 0 or 1? Now the code does nothing
in that case and you get the default value.
I don't know if this can happen or what has been said about this attribute
regarding values.
Is IMM checking this value? Is it prepared for future use where it can have
other values, in that case I guess it should be kept as is.
Maybe remove the else with the logging so it always logging in case you pass
the checks without handling it.
I don't really know but I feel something is missing.
/Bertil
-----Original Message-----
From: Robert Apanowicz
Sent: den 5 december 2014 09:55
To: Ingvar Bergström; Bertil Engelholm
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] smf: reading of longDnsAllowed attribute does not block
[#1230]
osaf/services/saf/smfsv/smfd/SmfUtils.cc | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
The reader function of "longDnsAllowed" IMM attribute changed to not block in
case of unsuccessful read of the attribute.
diff --git a/osaf/services/saf/smfsv/smfd/SmfUtils.cc
b/osaf/services/saf/smfsv/smfd/SmfUtils.cc
--- a/osaf/services/saf/smfsv/smfd/SmfUtils.cc
+++ b/osaf/services/saf/smfsv/smfd/SmfUtils.cc
@@ -758,10 +758,11 @@ SmfImmUtils::read_IMM_long_DN_config_and
TRACE_LEAVE();
return true;
}
+ } else {
+ LOG_NO("Could not get long DN config [%s %s], use default DN
length",
+IMM_LONG_DN_CONFIG_ATTRIBUTE_NAME, IMM_CONFIG_OBJECT_DN);
}
- LOG_ER("Could not get long DN config from IMM attr %s %s",
IMM_LONG_DN_CONFIG_ATTRIBUTE_NAME, IMM_CONFIG_OBJECT_DN);
TRACE_LEAVE();
- return false;
+ return true;
}
//
------------------------------------------------------------------------------
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
