Summary: amfd: adjust rank of all csis in SI if csidep is deleted [#1240]. 
Review request for Trac Ticket(s): #1240 
Peer Reviewer(s): Hans N., Nagendra 
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default 
Development branch: <<IF ANY GIVE THE REPO URL>>

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 3f6ac03bda430ac71b48bb1413409e85413019ca
Author: [email protected]
Date:   Thu, 15 Jan 2015 14:49:18 +0530

        amfd: adjust rank of all csis in SI if csidep is deleted [#1240]

        Before unlock and unlock-in operation, user deletes CSI dependency via 
CCB
        modification. After this when unlock-in and unlock operations are 
performed,
        AMF did not give callback to components for some CSIs.

        While deleting CSI dependency, AMF assigns rank 1 to the deleted CSI in 
SI
        if this CSI has no further sponsor. But AMF is not cheking if this CSI 
is
        sponsor to some other CSI recursively. Due to this there was no CSI with
        rank 2 in this SI when this CSI of rank 2 was deleted. Now AMFND 
assigns CSI
        of rank r+1 when csi of rank r is assigned. Since there was no CSI with 
rank
        2, AMFND skipped assignments when CSI of rank 1 was assigned assuming 
there
        are no further CSIs to be assigned. Thus CSI of rank 3 remained 
unassigned.
        So deletion of CSI dependency requires recalculation of ranks of all the
        CSIs in SI.

        Patch fixed the problem by performing recalculation of ranks of all 
CSIs in
        a SI when CSI dependency is deleted through CCB modification.


Complete diffstat:
------------------
 osaf/services/saf/amf/amfd/csi.cc |  17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)


Testing Commands:
-----------------
Tested as per ticket description.

Testing, Expected Results:
--------------------------
All CSIs are getting assigned.

Conditions of Submission:
-------------------------
Ack from atleast one reviewer.

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to