Summary: amfd: add mutex to sync up among amfd threads [#405, #707] Review request for Trac Ticket(s): #405, #707 Peer Reviewer(s): Hans N, Mathi, Praveen, Anders Bj, Anders Widell Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 8cf4e73e0bf50ed7200401572d41005201626d3d Author: Nagendra Kumar<[email protected]> Date: Thu, 26 Feb 2015 11:48:43 +0530 amfd: add mutex to sync up among amfd threads [#405, #707] If imm returns BAD HANDLE to Amf, Amf reinitializes with imm intf in a separate thread. If role change event comes during imm intf initialization time, ImplSet, ImplClear, etc fails with BAD HANDLE. So, Amf need to take mutex and wait for imm intf initialization. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/imm.cc | 30 ++++++++++++++++++++- osaf/services/saf/amf/amfd/role.cc | 117 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------- 2 files changed, 125 insertions(+), 22 deletions(-) Testing Commands: ----------------- Test Scenarios of #405 and #707. Testing, Expected Results: -------------------------- No crash of Amfd. Conditions of Submission: ------------------------- Ack from maintainers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
