Summary: amfd: send commit message after async updates [#371]
Review request for Trac Ticket(s): #371
Peer Reviewer(s): Hans N, Praveen
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset c2364a656a6fafc13ffdd525140bb026b0fd586e
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Thu, 12 Mar 2015 12:31:26 +0530
amfd: send commit message after async updates [#371] During switchover,
if
payload is being stopped, Standby Amfd crashes in avd_dec_warm_sync_rsp
because of counter mismatch. Counter mismatch happens because newly Act
Amfd
updates its own counters in avd_node_failover in
handle_event_in_failover_state, and sends it to its Standby peer, but it
doesn't send AVSV_SYNC_COMMIT to its Standby peer. Once
AVSV_SYNC_COMMIT is
received by Standby Amfd, it processes those messages and updates its
ounter
and become in sync with Act Amfd. Since Act Amfd has updated counter and
AVSV_SYNC_COMMIT is not sent, Standby Amfd has older counters. Now, if
warm
sync request comes at Act Amfd at this point of time, then Act Amfd
fills
updated counter and sends it to Standby Amfd. Now, Standby Amfd receives
warn sync message and compares them with its own counter, which is
older,
because it has not processed those aync update as Act Amfd didn't send
AVSV_SYNC_COMMIT message. Since counters will be out of sync and Standby
Amfd will crash.
So, if Act Amfd sends AVSV_SYNC_COMMIT message, Standby Amfd will
process
sync updates and will have its counters updated. This will avoid
counters
mismatch at Standby Amfd and will avoid the crash.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/main.cc | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
Configure AVSV_HB_PERIOD as 30 sec in /etc/opensaf/amfd.conf at
SC-2 and set NCS_MBCSV_OBJ_TMR_WSYNC as 10 sec by calling avsv_mbcsv_obj_set()
in both Amfd as below:
diff --git a/osaf/services/saf/amf/amfd/chkop.cc
b/osaf/services/saf/amf/amfd/chkop.cc
--- a/osaf/services/saf/amf/amfd/chkop.cc
+++ b/osaf/services/saf/amf/amfd/chkop.cc
@@ -97,6 +97,8 @@ uint32_t avsv_mbcsv_register(AVD_CL_CB *
if (NCSCC_RC_SUCCESS != (status = avsv_mbcsv_open_ckpt(cb)))
goto done_final;
+ if (NCSCC_RC_SUCCESS != (status =
avsv_mbcsv_obj_set(cb,NCS_MBCSV_OBJ_TMR_WSYNC, 1100)))
+ goto done_final;
/*
* Get MBCSv selection object.
1. Start 2 controllers(SC-2 as Standby) and one payload.
2. When Standby sends HB message to Amfnd, then perform controller
switchover and stop payload.
Newly Standby Amfd will crash.
Testing, Expected Results:
--------------------------
Standby Amfd will not crash.
Conditions of Submission:
-------------------------
Ack from reviewers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
