Summary: IMM: Halt sync with SIGKILL insted of SIGTERM and replace assert with 
error [#1295]
Review request for Trac Ticket(s): 1295
Peer Reviewer(s): Neel; Zoran
Pull request to: 
Affected branch(es): 4.4; 4.5; 4.6: default(4.7)
Development branch: 

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        y
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 027d50d366a89fd40049c8e54b72089ce19a0437
Author: Anders Bjornerstedt <[email protected]>
Date:   Thu, 09 Apr 2015 06:46:10 +0200

        IMM: Halt sync with SIGKILL insted of SIGTERM and replace assert with 
error
        [#1295]

        The problem was triggerde by the handling of the unusual case of a PRTA
        update failing during on going sync due to PBE being configured but
        unavailable at that time. Such a failed PRTA update has to abort the 
sync
        becasue the PRTA update may succeed at sync clients yet fail at 
veterans.
        This is due to the sync clients possibly not yet having synced the 
config
        data specifying if PBE is available or not.

        The handling of this case by the IMMND coord was to send a SIGTERM to 
the
        sync-process and to broacast an abort of the cluster wide sync job over
        fevs. A SIGERM may however be slow to get processed by the sync 
process. If
        the abort of the sync job gets handled before the sync process has
        terminated; and the sync process sends additional sync messages 
arriving at
        a processor after the sync has been aborted, then the assert will get
        triggered.

        The solution is to replace the SIGTERM with SIGKILL. THat should 
drastically
        reduce the probability of the sync process lingering after the sync job 
has
        been aborted in the IMMND cluster. In addition the assert is dissarmed 
and
        replaced with a return of error (to the sync process) for this case.


Complete diffstat:
------------------
 osaf/services/saf/immsv/immnd/ImmModel.cc |  6 +++++-
 osaf/services/saf/immsv/immnd/immnd_evt.c |  2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)


Testing Commands:
-----------------
Complicated to set up a test for.
One has to have periodic PRTA updates.
Trigger a sync to start and kill the PBE.
The sync needs to be large enough so that time enough is given
to the tester to kill the PBE after sync has started but before 
sync has completed. 


Testing, Expected Results:
--------------------------
The assert shall no longer be obsered. 
Instead the sync process should get aborted by the SIGKILL or termiante
itself by getting error while building the next sync batch.

Conditions of Submission:
-------------------------
Ack from Neel.


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to