Hi,

Ack, only reviewed.
Br,

Robert

On 04/14/2015 08:40 AM, [email protected] wrote:
> Summary: smfd: adjust smfRebootTimeout to include time spent in 
> getNodeDestination v2 [#1272]
> Review request for Trac Ticket(s): #1272
> Peer Reviewer(s): Robert, Ingvar (Alex, everyone interested)
> Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
> Affected branch(es): opensaf-4.5.x, 4.6.x, default
> Development branch: <<IF ANY GIVE THE REPO URL>>
>
> --------------------------------
> Impacted area       Impact y/n
> --------------------------------
>   Docs                    n
>   Build system            n
>   RPM/packaging           n
>   Configuration files     n
>   Startup scripts         n
>   SAF services            y
>   OpenSAF services        n
>   Core libraries          n
>   Samples                 n
>   Tests                   n
>   Other                   n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
>
> changeset 9b29d4d6bd641d0ffb0cd1e1f8131b483d4182e0
> Author:       Mathivanan N.P.<[email protected]>
> Date: Tue, 14 Apr 2015 12:03:09 +0530
>
>       smfd: smfd: adjust smfRebootTimeout to include time spent in
>       getNodeDestination v2 [#1272] The smfRebootTimeout indicates the 
> timeperiod
>       for which SMF should wait for a rebooted node to come up as a part of 
> the
>       SmfUpgradeStep::nodeReboot step. However, currently additional time can 
> get
>       consumed when waiting for smfnd and eventually not matching the
>       smfRebootTimeout parameter set by the user. The patch includes the time
>       spent in getNodeDestination also to calculate the smfRebootTimeout.
>
>
> Complete diffstat:
> ------------------
>   osaf/services/saf/smfsv/smfd/SmfUpgradeAction.cc |   4 ++--
>   osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc   |  32 
> ++++++++++++++++++++++++--------
>   osaf/services/saf/smfsv/smfd/SmfUtils.cc         |  20 ++++++++++++++------
>   osaf/services/saf/smfsv/smfd/SmfUtils.hh         |   2 +-
>   osaf/services/saf/smfsv/smfd/smfd.h              |   2 ++
>   5 files changed, 43 insertions(+), 17 deletions(-)
>
>
> Testing Commands:
> -----------------
> As a part of the nodeReboot step, ensure that the maximum
> time spent for the rebooted node to comeup is smfRebootTimeout.
>
> Testing, Expected Results:
> --------------------------
> Same as above.
>
> Conditions of Submission:
> -------------------------
> Ack from Robert, Ingvar.
>
> Arch      Built     Started    Linux distro
> -------------------------------------------
> mips        n          n
> mips64      n          n
> x86         n          n
> x86_64      y          y
> powerpc     n          n
> powerpc64   n          n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
>      that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
>      (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
>      Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
>      like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
>      cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
>      too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
>      Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
>      commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
>      of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
>      comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
>      the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
>      for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
>      do not contain the patch that updates the Doxygen manual.
>


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to