Summary: Re-align SG if NodeFailover happens at quiesced assignment during si-swap [#1312] Review request for Trac Ticket(s): 1312 Peer Reviewer(s): Hans N, Nagu, Praveen Pull request to: Affected branch(es): 4.5, 4.6, default(4.7) Development branch: default(4.7)
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch is for 4.5 branch changeset 8b8bcfc89b497e2e84bc9bb691263ad894bbbee3 Author: Minh Hon Chau <[email protected]> Date: Fri, 17 Apr 2015 11:46:19 +1000 amfd: Re-align SG if NodeFailover happens at quiesced assignment during si- swap [#1312] During si-swap, node-failover happens on the node which's su just finishes quiesced assignment, and su on the other node has not done active assignment. Then if the node comes up after reboot, SG will left as unstable. As node-failover happens, node_fail_su_oper() set the SG stable. Then all components reponse for active assignment, the susi_success() currently does nothing in SG stable state with susi modify action, so no active assignment as result. Then the standby node comes up, initiates the standby assignment but no active assignment. Therefore the SG is left as unstable at the end. Patch sets SG to re-align in node_fail_su_oper() as the other node fails over. At re-align state, SG currently can handle response from active assignment and standby assignment from the rebooted node. Note that if just leaves SG as su-oper state, once active assignment is done, the susi_success_su_oper() will send susi_modify for standby assignment. That could run into problem as there is no standby assignment at moment due to node reboot. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 43 ++++++++++++++++++++++++++++++++++++------- 1 files changed, 36 insertions(+), 7 deletions(-) Testing Commands: ----------------- Retest with model attached to ticket in addition to inject fault during quiesced assignment, delay active assignment, delay node reboot during si-swap test Testing, Expected Results: -------------------------- after node comes up, both active/standby assignment is done, be able to run another si-swap Conditions of Submission: ------------------------- ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
