Summary: amfd: validate node for being nodegroup member [#1311]
Review request for Trac Ticket(s): #1311
Peer Reviewer(s): Hans N, Praveen
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): All
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 4d76c4442805e83eaa7954e31cee26a604d63c13
Author: Nagendra Kumar<nagendr...@oracle.com>
Date: Wed, 22 Apr 2015 16:39:04 +0530
amfd: validate node for being nodegroup member [#1311] Amfd is allowing
node
to be deleted even if node is being part of node group. This creates
database differences because that node is still part of node group, but
it
doesn's exists. When a nodegroup is created and node is added to it,
Amfd
checks whether node exists or not. If it doesn't exist, then node
addition
fails. This is done in the expectation that node should exists if it
want to
be part of node group. This concept should go inline with deletion of
node
as well and node deletion shouldn't be allowed until it is part of a
nodegroup.
A valiadation has been added when node is being deleted for its
membership
of a node group. If node is a part of membership, it can't be deleted.
So,
to delete a node, first delete that node from node group.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/node.cc | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
Testing Commands:
-----------------
1. Start SC-1 with 4 nodes configuration. Lock/lock-in PL-3. Try deleting PL-3 :
immcfg -d safAmfNode=PL-3,safAmfCluster=myAmfCluster
2. After step 1, Delete PL-3 from node group AllNodes:
immcfg -m -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster
safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster
3. Delete mw SUs from PL-3:
immcfg -d safSu=PL-3,safSg=NoRed,safApp=OpenSAF
Now run the step 2 command.
4. Now try deleting PL-3 : immcfg -d safAmfNode=PL-3,safAmfCluster=myAmfCluster
5. Now delete PL-3 from node group PLs:
immcfg -m -a saAmfNGNodeList-=safAmfNode=PL-3,safAmfCluster=myAmfCluster
safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
Now delete the node PL-3: immcfg -d
safAmfNode=PL-3,safAmfCluster=myAmfCluster
6. Now lock and unlock the node group as per ticket description:
amf-adm lock safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
amf-adm unlock safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
7. Delete the node group: immcfg -d
safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster
Testing, Expected Results:
--------------------------
1. Deletion of PL-3 fails with:
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
OI reports: 'safAmfNode=PL-3,safAmfCluster=myAmfCluster' exists in the
nodegroup 'safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster'
2. The following error will come:
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
OI reports: Cannot delete 'safAmfNode=PL-3,safAmfCluster=myAmfCluster' from
'safAmfNodeGroup=AllNodes,safAmfCluster=myAmfCluster'. An SU is mapped using
node group
3. Deletion of PL-3 node from safAmfNodeGroup will succeed.
4. Fails with the following error:
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
OI reports: 'safAmfNode=PL-3,safAmfCluster=myAmfCluster' exists in the
nodegroup 'safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster'
5. Deletion of PL-3 succeeds.
6. Lock and unlock on the node group
'safAmfNodeGroup=PLs,safAmfCluster=myAmfCluster' succeeds.
7. Delete of the node group succeeds.
Conditions of Submission:
-------------------------
Ack from peer maintainers.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
