Ack, code review only.

Thanks,
Praveen

On 07-Apr-15 2:33 PM, [email protected] wrote:
>   osaf/services/saf/amf/amfd/sgproc.cc |  8 ++++++++
>   1 files changed, 8 insertions(+), 0 deletions(-)
>
>
> Amfd is not decrementing saAmfSINumCurrStandbyAssignments when
> HA state is changing from Quisced to Standby during SU failover.
> saAmfSINumCurrStandbyAssignments is increased when Amfd sends
> assignment to Amfnd from Quisced to Standby, it need to decrement
> saAmfSINumCurrStandbyAssignments if failover happens and assignment was
> not successfull.
>
> diff --git a/osaf/services/saf/amf/amfd/sgproc.cc 
> b/osaf/services/saf/amf/amfd/sgproc.cc
> --- a/osaf/services/saf/amf/amfd/sgproc.cc
> +++ b/osaf/services/saf/amf/amfd/sgproc.cc
> @@ -464,7 +464,15 @@ static uint32_t sg_su_failover_func(AVD_
>                                  assignment had been sent. So decrement the 
> count in SI before
>                                  deleting the SUSI. */
>                               susi->si->dec_curr_act_ass();
> +                     } else if ((susi->fsm == AVD_SU_SI_STATE_MODIFY) &&
> +                                     (susi->state == SA_AMF_HA_STANDBY)) {
> +                             /* SUSI is undergoing standby modification. For 
> standby state
> +                                saAmfSINumCurrStandbyAssignments was 
> increased when standby
> +                                assignment had been sent. So decrement the 
> count in SI before
> +                                deleting the SUSI. */
> +                             susi->si->dec_curr_stdby_ass();
>                       }
> +
>                       /* Reply to IMM for admin operation on SI */
>                       if (susi->si->invocation != 0) {
>                               
> avd_saImmOiAdminOperationResult(avd_cb->immOiHandle,
>

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to