Hi Nagu, please see below. /Thanks HansN
On 05/06/2015 10:51 AM, Nagendra Kumar wrote: > > Hi Hans N, > > >> perhaps the comment above the change need to be updated > > I didn’t get it. Please specify the comment you are pointing. > > Thanks > > -Nagu > > *From:*Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > *Sent:* 05 May 2015 17:21 > *To:* Nagendra Kumar; Praveen Malviya > *Cc:* opensaf-devel@lists.sourceforge.net > *Subject:* Re: [PATCH 1 of 1] amfd: send data verify message to node > in NO_CONFIG and NCS_INIT also [#1359] > > ack, code review only, perhaps the comment above the change need to be > updated/Thanks HansN > > On 04/30/2015 02:11 PM, nagendr...@oracle.com > <mailto:nagendr...@oracle.com> wrote: > > osaf/services/saf/amf/amfd/ndfsm.cc | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > When Amfd is comming up as Act, it is not sending data verify message to > node, > > which is in state AVD_AVND_STATE_NO_CONFIG and AVD_AVND_STATE_NCS_INIT. > > This creates problem of marking the upcoming node in > AVD_AVND_STATE_GO_DOWN and > > this stops that node to join the cluster. > > When node has just come up and sent node up message to Act amfd and at > that time > > if Act Amfd node goes for switchover or failover, then that node has to > > contact to newly Act Amfd for further communication. > > So, that node needs to get data verify message from newly Amfd. > > > > diff --git a/osaf/services/saf/amf/amfd/ndfsm.cc > b/osaf/services/saf/amf/amfd/ndfsm.cc > > --- a/osaf/services/saf/amf/amfd/ndfsm.cc > > +++ b/osaf/services/saf/amf/amfd/ndfsm.cc > > @@ -405,7 +405,9 @@ void avd_fail_over_event(AVD_CL_CB *cb) > > * Check if we are in present state. If yes then send > DATA verify > [HansN] the above comment, perhaps change to "Check if we are in present state and ... > > * message to all the AVND's. > > */ > > - if (AVD_AVND_STATE_PRESENT == avnd->node_state) { > > + if ((AVD_AVND_STATE_PRESENT == avnd->node_state) || > > + (AVD_AVND_STATE_NO_CONFIG == > avnd->node_state) || > > + (AVD_AVND_STATE_NCS_INIT == > avnd->node_state)) { > > /* > > * Send verify message to this node. > > */ > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
