Summary: amfd: try again if ImplementerClear times out Review request for Trac Ticket(s): #1360 Peer Reviewer(s): Praveen, Hans N Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 158ee89b2519138b736b3466575c943bb8283fe1 Author: Nagendra Kumar<[email protected]> Date: Tue, 12 May 2015 14:06:04 +0530 amfd: try again if ImplementerClear times out ImplementerClear returns SA_AIS_ERR_TIMEOUT because the message sent from immnd to immd got lost because of node down. So, Amf need to handle it as try_again. After Amf does try_again, Imm returns SA_AIS_ERR_BAD_HANDLE. Amf handles SA_AIS_ERR_BAD_HANDLE and reinitializes its interface with Imm. In handling SA_AIS_ERR_BAD_HANDLE, Amf sets the implementer in avd_imm_reinit_bg_thread, so when Amf proceeds and calls avd_imm_applier_set, Imm returns SA_AIS_ERR_INVALID_PARAM. Since, it is expected error from Imm, Amf ignores it. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/role.cc | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) Testing Commands: ----------------- 1. Start SC-1(Act) and SC-2(Std). 2. Keep sleep in immd_evt_proc_fevs_req at SC-2 when Amf calls ImplementerClear. 3. Issue si swap, when immd sleeps, do 'kill -9 osaf' and opensafd stop at SC-2. Testing, Expected Results: -------------------------- Amfd doesn't crash. Snaps of syslog below: May 12 13:06:37 PM_SC-1 osafamfd[9619]: ER FAILOVER Active --> Quiesced FAILED, ImplementerClear failed 5 May 12 13:06:37 PM_SC-1 osafimmnd[9564]: WA ERR_BAD_HANDLE: Handle use is blocked by pending reply on syncronous call May 12 13:06:37 PM_SC-1 osafimmnd[9564]: NO Implementer locally disconnected. Marking it as doomed 3 <15, 2010f> (safAmfService) May 12 13:06:37 PM_SC-1 osafamfd[9619]: ER FAILOVER Active --> Quiesced FAILED, ImplementerClear failed 9 May 12 13:06:37 PM_SC-1 osafamfd[9619]: NO Re-initializing with IMM May 12 13:06:37 PM_SC-1 osafimmnd[9564]: WA IMMND - Client Node Get Failed for cli_hdl 64424640783 May 12 13:06:45 PM_SC-1 osafamfd[9619]: NO Finished re-initializing with IMM May 12 13:06:45 PM_SC-1 osafamfd[9619]: NO ERR_INVALID_PARAM: Implementer @safAmfService2010f already set for this handle when trying to set @safAmfService2010f May 12 13:06:45 PM_SC-1 osafamfd[9619]: ER saImmOiImplementerSet failed 7 May 12 13:06:45 PM_SC-1 osafamfd[9619]: ER avd_imm_applier_set FAILED, 7 May 12 13:06:45 PM_SC-1 osafamfd[9619]: ER Either of ERR_EXISTS or ERR_INVALID, 7 May 12 13:06:45 PM_SC-1 osafamfd[9619]: NO ROLE SWITCH Quiesced --> Active May 12 13:06:45 PM_SC-1 osafrded[9535]: NO RDE role set to ACTIVE May 12 13:06:45 PM_SC-1 osafclmd[9600]: NO ACTIVE request May 12 13:06:45 PM_SC-1 osafamfd[9619]: NO Switching StandBy --> Active State Conditions of Submission: ------------------------- Ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
