Summary: amfd: ignore invalid modification of saAmfSGMaxActiveSIsperSU/saAmfSGMaxStandbySIsperSU [#1361] Review request for Trac Ticket(s): #1361 Peer Reviewer(s): Praveen, Hans N Pull request to: Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 84a2c3af30afe1c9b87f7fadd663b117010936fa Author: Nagendra Kumar<[email protected]> Date: Thu, 21 May 2015 12:30:51 +0530 amfd: ignore invalid modification of saAmfSGMaxActiveSIsperSU/saAmfSGMaxStandbySIsperSU [#1361] saAmfSGMaxActiveSIsperSU is valid for NPM, N_WAY and N_WAY_ACTIVE and invalid for Nored and 2N. So, modification of this attribute for Nored and 2N redudancy models should be ignored. saAmfSGMaxStandbySIsperSU is valid for NPM and N_WAY and invalid for Nored, 2N and NwayAct. So, modification of this attribute for Nored, 2N and NwayAct redudancy models should be ignored. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sg.cc | 31 +++++++++++++++++++++++++------ 1 files changed, 25 insertions(+), 6 deletions(-) Testing Commands: ----------------- 1. Configure amf demo as SU1(Act on SC-1), SU2(Std on SC-2) and SU3(SC-2) [2N Red model]. immcfg -f /tmp/AppConfig.xml amf-adm unlock-in safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm unlock safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm unlock-in safSu=SU2,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm unlock safSu=SU2,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm unlock-in safSu=SU3,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm unlock safSu=SU3,safSg=AmfDemo_2N,safApp=AmfDemo1 amf-adm lock safSg=AmfDemo_2N,safApp=AmfDemo1 immcfg -m -a saAmfSGMaxActiveSIsperSU=0 safSg=AmfDemo_2N,safApp=AmfDemo1 2. Repeat the above test cases with redundancy model as Nored. 3. Repeat the above test cases for saAmfSGMaxStandbySIsperSU with Nored/2N/NwayAct red models. Testing, Expected Results: -------------------------- 1. The CCB is commited with the following logs: May 21 12:20:18 PM_SC-1 osafamfd[19800]: NO 'safSg=AmfDemo_2N,safApp=AmfDemo1' attribute saAmfSGMaxActiveSIsperSU not modified, not valid for Nored/2N Redundancy models Amfd doesn't crashes in amf-adm lock safSg=AmfDemo_2N,safApp=AmfDemo1 2. The same as above. 3. The CCB is commited with the following logs: May 20 15:05:48 PM_SC-1 osafamfd[9610]: NO 'safSg=AmfDemo_2N,safApp=AmfDemo1' attribute saAmfSGMaxStandbySIsperSU not modified, not valid for Nored/2N/NwayAct Redundancy models Amfd doesn't crashes in amf-adm lock safSg=AmfDemo_2N,safApp=AmfDemo1 Conditions of Submission: ------------------------- Ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
