Hi Neel,
Yes I checked the code before the patch and the if statement in
ImmModel::accessorGet:
SaAisErrorT
@@ -10051,6 +10060,10 @@ ImmModel::accessorGet(const ImmsvOmSearc
SaImmSearchOptionsT notAllowedOptions = 0LL;
bool nonExtendedNameCheck = req->searchParam.present >
ImmOmSearchParameter_PR_oneAttrParam;
bool checkAttribute = false;
+
+ if(nonExtendedNameCheck) {
+ op.setNonExtendedName();
+ }
was redundant even before this #674 patch.
Before this patch, accessorGet was invoked from ImmModel::searchInitialize().
Which had already invoked the same ifstatement.
I will remove this redundant code before pushing.
Thanks,
AndersBj
-----Original Message-----
From: Neelakanta Reddy [mailto:[email protected]]
Sent: den 28 maj 2015 08:21
To: Anders Björnerstedt
Cc: [email protected]
Subject: Re: [PATCH 0 of 1] Review Request for IMM: Detour of accessorGet into
ImmModel::searchInitialize removed [#674]
Hi AndersBj,
Reviewed and tested the patch.
Ack with the following comment.
comment:
The following changes already present in the ImmModel::accessorGet.
This change is a duplicate.
SaAisErrorT
@@ -10051,6 +10060,10 @@ ImmModel::accessorGet(const ImmsvOmSearc
SaImmSearchOptionsT notAllowedOptions = 0LL;
bool nonExtendedNameCheck = req->searchParam.present >
ImmOmSearchParameter_PR_oneAttrParam;
bool checkAttribute = false;
+
+ if(nonExtendedNameCheck) {
+ op.setNonExtendedName();
+ }
/Neel.
On Tuesday 26 May 2015 06:07 PM, Anders Bjornerstedt wrote:
> Summary: IMM: Detour of accessorGet into ImmModel::searchInitialize
> removed [#674] Review request for Trac Ticket(s): 674 Peer
> Reviewer(s): Neel; Zoran Pull request to:
> Affected branch(es): default(4.7)
> Development branch: default(4.7)
>
> --------------------------------
> Impacted area Impact y/n
> --------------------------------
> Docs n
> Build system n
> RPM/packaging n
> Configuration files n
> Startup scripts n
> SAF services y
> OpenSAF services n
> Core libraries n
> Samples n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
>
> changeset ec4019e68ed3a24a738d9cc403fb7277e188f0d6
> Author: Anders Bjornerstedt <[email protected]>
> Date: Tue, 26 May 2015 14:08:00 +0200
>
> IMM: Detour of accessorGet into ImmModel::searchInitialize removed
> [#674]
>
> The detour seemed mostly to deal with handling of the SaImmScopeT type.
> The
> scope of SA_IMM_ONE is only relevant for accessors and there it is
> implicit,
> since that function only deals with fetching attributes from one imm
> object.
>
>
> Complete diffstat:
> ------------------
> osaf/services/saf/immsv/immnd/ImmModel.cc | 30
> +++++++++++++++---------------
> osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
> 2 files changed, 16 insertions(+), 16 deletions(-)
>
>
> Testing Commands:
> -----------------
> This is a minor code cleanup.
> No change in behavior is expected.
>
>
> Testing, Expected Results:
> --------------------------
> All/any regression test should pass.
>
>
> Conditions of Submission:
> -------------------------
> Ack from Neel.
>
>
> Arch Built Started Linux distro
> -------------------------------------------
> mips n n
> mips64 n n
> x86 n n
> x86_64 n n
> powerpc n n
> powerpc64 n n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any
> checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
> that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
> (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
> Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
> like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
> cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
> too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
> Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
> commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
> of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
> comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
> the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
> for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
> do not contain the patch that updates the Doxygen manual.
>
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
