HI Hung, Reviewed and tested the patch. Ack.
/Neel. On Friday 05 June 2015 09:50 AM, Hung Nguyen wrote: > Summary: imm: IMM deletes object with NO_DANGLING reference [#1377] > Review request for Trac Ticket(s): 1377 > Peer Reviewer(s): AndersB, Nell, Zoran > Pull request to: > Affected branch(es): 4.5, 4.6, default(4.7) > Development branch: default(4.7) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 7a8f6e4c5454d9eb90b46eeea02c689910fcf3d2 > Author: Hung Nguyen <[email protected]> > Date: Fri, 05 Jun 2015 11:14:41 +0700 > > imm: Check no-dangling map before adding new references when committing > modify-op [#1377] > > In commitModify() IMM_CREATE_LOCK flag is used to test to avoid adding > duplicated no-dangling references. When an IMM_CREATE mutation is > committed, > the IMM_CREATE_LOCK flag is also cleared in commitCreate(). If the CCB > has > IMM_MODIFY mutations that add references to object of committed > IMM_CREATE > mutations, it will fail to add NO_DANGLING references to > sReverseRefsNoDanglingMMap in addNewNoDanglingRefs() due to cleared > IMM_CREATE_LOCK flag. mMutations map is sorted by object DN so the > order of > mutations to be committed depends on the object DNs. > > This patch introduces new method to avoid adding duplicated references > instead of using IMM_CREATE_LOCK flag. No-dangling references will only > be > added if they don't currently exist in the map. > > > Complete diffstat: > ------------------ > osaf/services/saf/immsv/immnd/ImmModel.cc | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > > Testing Commands: > ----------------- > # immcfg -c TestClass testClassId=2 > # immcfg >> immcfg -c TestClass testClassId=1 >> immcfg -a reference="testClassId=1" testClassId=2 >> (Ctrl+D) > > Testing, Expected Results: > -------------------------- > # immcfg -d testClassId=1 > error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21) > > > Conditions of Submission: > ------------------------- > Ack from reviewers. > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
