Summary: amfnd: wait for applcation exit during its termimation [#1375] Review request for Trac Ticket(s): #1375 Peer Reviewer(s): Praveen, Hans N, Mathi, Anders W Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset e79a993667ee0ba741d3205d29e09e2439e842be Author: Nagendra Kumar<[email protected]> Date: Tue, 09 Jun 2015 19:07:52 +0530 amfnd: wait for applcation exit during its termimation [#1375] During appl termination, amf issues instantiate cmd immediately after it receives appl termination resp. There is possibility that application may not have exited before Amf issues instantiate cmd and instantiate command may hang. So, Amf need to wait till appl exit after Amf receives termination response. If appl doesnot exit within termination cbk timeout, then Amf sends cleanup command. If there is some fault(like error report) happened after appl sends term resp and before application exits, Amf will take actions accordingly. Complete diffstat: ------------------ osaf/services/saf/amf/amfnd/cbq.cc | 31 +++++++++++++++++++++++++++---- osaf/services/saf/amf/amfnd/comp.cc | 14 +++++++++++++- osaf/services/saf/amf/amfnd/err.cc | 12 ++++++++++++ osaf/services/saf/amf/amfnd/include/avnd_comp.h | 1 + 4 files changed, 53 insertions(+), 5 deletions(-) Testing Commands: ----------------- 1. Configure Sa-Aware PI component. 1.1 Lock-in: Respond Amf for term callback and exit after delay. Appl gets successfully uninstantiated. 1.2. Lock-in: Donot send term cbk response and allow timeout to happen. Appl gets cleanup and becomes uninstantiated. 1.3. Component restart: Respond Amf for term callback and exit after delay. Appl gets successfully instantiated. 1.4. Component restart: Donot send term cbk response and allow timeout to happen. Appl gets successfully instantiated. 2. Configure proxied PI component and repeat the above cases. Testing, Expected Results: -------------------------- 1.1 Appl/su gets successfully uninstantiated. 1.2 Appl/su gets cleanup and becomes uninstantiated. 1.3 Appl gets successfully instantiated. 1.4 Appl gets successfully instantiated. The same happens for proxied PI component. Conditions of Submission: ------------------------- Ack from peer reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
