ack, code review only.
On 23/06/15 21:11, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfnd/clc.cc | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>
> When Su is in instantiated state(with one component configured with
> component-failover)
> and is in unassigned state and if component crashes, then
> Amf is not marking SU in instantiating state when Amf is
> instantiating the component in that SU.
> This leads to SU remain in uninstantiated state.
> So, Amf now marks Su in instantiating state if the component in that
> SU is getting instantiated.
>
> diff --git a/osaf/services/saf/amf/amfnd/clc.cc
> b/osaf/services/saf/amf/amfnd/clc.cc
> --- a/osaf/services/saf/amf/amfnd/clc.cc
> +++ b/osaf/services/saf/amf/amfnd/clc.cc
> @@ -438,6 +438,7 @@ uint32_t avnd_evt_comp_pres_fsm_evh(AVND
> AVND_COMP_FSM_EVT *comp_fsm_evt = &evt->info.comp_fsm;
> AVND_COMP *comp = 0;
> uint32_t rc = NCSCC_RC_SUCCESS;
> + bool is_uninst = false;
> TRACE_ENTER();
>
> /* get the comp */
> @@ -445,10 +446,18 @@ uint32_t avnd_evt_comp_pres_fsm_evh(AVND
> if (!comp)
> goto done;
>
> + if (all_comps_terminated_in_su(comp->su) == true)
> + is_uninst = true;
> +
> +
> /* run the fsm */
> if (AVND_COMP_CLC_PRES_FSM_EV_MAX != comp_fsm_evt->ev)
> rc = avnd_comp_clc_fsm_run(cb, comp,
> static_cast<AVND_COMP_CLC_PRES_FSM_EV>(comp_fsm_evt->ev));
>
> + if ((is_uninst == true) &&
> + (comp->pres == SA_AMF_PRESENCE_INSTANTIATING))
> + avnd_su_pres_state_set(comp->su, SA_AMF_PRESENCE_INSTANTIATING);
> +
> done:
> TRACE_LEAVE2("%u", rc);
> return rc;
>
> ------------------------------------------------------------------------------
> Monitor 25 network devices or servers for free with OpManager!
> OpManager is web-based network management software that monitors
> network devices and physical & virtual servers, alerts via email & sms
> for fault. Monitor 25 devices for free with no restriction. Download now
> http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
