Sorry, please ignore this. I will send a revised patch. On 09/07/15 13:33, Gary Lee wrote: > Summary: amfd: ignore invalid operations on nodegroup [#1389] > Review request for Trac Ticket(s): 1389 > Peer Reviewer(s): Praveen, Nagandra, Quyen > Pull request to: Praveen > Affected branch(es): default, opensaf-4.6.x > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset d7c845cffab63d8f21b114505ef5acb834f5a9ef > Author: Gary Lee <[email protected]> > Date: Thu, 09 Jul 2015 12:27:35 +1000 > > amfd: ignore invalid operations on nodegroup [#1389] > > If a lock-in operation is ordered on a nodegroup, only perform this on a > node if the node is in 'locked' state. > > If an unlock-in operation is ordered on a nodegroup, only perform this > on a > node if it's in the 'locked instantiation' state. > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfd/nodegroup.cc | 31 > +++++++++++++++++++------------ > 1 files changed, 19 insertions(+), 12 deletions(-) > > > Testing Commands: > ----------------- > > - Load the NWayActive model (AppConfig-nwayactive.xml) and unlock-in then > unlock all the SUs > > - Create a node group containing PL-3 and PL-4 with admin state as > LOCKED-INSTANTIATION > > immcfg -c SaAmfNodeGroup safAmfNodeGroup=TestNG,safAmfCluster=myAmfCluster -a > saAmfNGNodeList=safAmfNode=PL-4,safAmfCluster=myAmfCluster -a > saAmfNGAdminState=3 > > immcfg -a saAmfNGNodeList+=safAmfNode=PL-3,safAmfCluster=myAmfCluster > safAmfNodeGroup=TestNG,safAmfCluster=myAmfCluster > > > amf-adm lock safAmfNode=PL-4,safAmfCluster=myAmfCluster > amf-adm lock-in safAmfNode=PL-4,safAmfCluster=myAmfCluster > amf-adm unlock-in safAmfNodeGroup=TestNG,safAmfCluster=myAmfCluster > amf-adm lock-in safAmfNodeGroup=TestNG,safAmfCluster=myAmfCluster > > Testing, Expected Results: > -------------------------- > > PL-3 does not reboot at the last command above. > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
