Summary: pyosaf: Fix broken modify_value_[add|replace|delete] methods in ccb.py [#1407] Review request for Trac Ticket(s): #1407 Peer Reviewer(s): [email protected], [email protected], [email protected] Pull request to: [email protected] Affected branch(es): opensaf-4.6.x Development branch: opensaf-staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- changeset 7c36d57b861a36beed80d6ea90b66d84052dcad9 Author: Johan Mårtensson <[email protected]> Date: Thu, 09 Jul 2015 15:41:07 +0200 pyosaf: Fix broken modify_value_[add|replace|delete] methods in ccb.py [#1407] Fix marshalling and wrong module prefixes in modify_value_add, modify_value_replace and modify_value_delete in ccb.py. Use the following steps to verify the fix: 1. Create a test class $ cat > testclass.xml <?xml version="1.0"?> <imm:IMM-contents xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:noNamespaceSchemaLocation="SAI-AIS-IMM-XSD-A.02.13.xsd" xmlns:xs="http://www.w3.org/2001/XMLSchema"; xmlns:imm="http://www.saforum.org/IMMSchema";> <class name="SampleClass"> <category>SA_CONFIG</category> <rdn> <name>sampleClassId</name> <type>SA_STRING_T</type> <category>SA_CONFIG</category> <flag>SA_INITIALIZED</flag> <flag>SA_NOTIFY</flag> </rdn> <attr> <name>attribute1</name> <type>SA_STRING_T</type> <category>SA_CONFIG</category> <flag>SA_WRITABLE</flag> <flag>SA_NOTIFY</flag> <flag>SA_MULTI_VALUE</flag> </attr> </class> </imm:IMM-contents> $ immcfg -f testclass.xml 2. Create an instance $ immcfg -c SampleClass sampleClassId=1 3. Test the methods in the Python shell $ python Python 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> >>> from pyosaf.utils.immom.ccb import Ccb >>> from pyosaf.utils import immom >>> test_object = immom.get('sampleClassId=1') >>> print test_object.attribute1 [] >>> >>> # Verify that modify_value_add works ... >>> ccb = Ccb() >>> ccb.modify_value_add("sampleClassId=1", "attribute1", ["a", "b"]) >>> ccb.apply() >>> >>> test_object = immom.get('sampleClassId=1') >>> print test_object.attribute1 ['a', 'b'] >>> >>> >>> # Verify that modify_value_replace works ... >>> ccb = Ccb() >>> ccb.modify_value_replace("sampleClassId=1", "attribute1", ["c", "d"]) >>> ccb.apply() >>> test_object = immom.get('sampleClassId=1') >>> >>> print test_object.attribute1 ['c', 'd'] >>> >>> >>> # Verify that modify_value_delete works ... >>> ccb = Ccb() >>> ccb.modify_value_delete("sampleClassId=1", "attribute1", ["c"]) >>> ccb.apply() >>> test_object = immom.get('sampleClassId=1') >>> print test_object.attribute1 ['d'] >>> Complete diffstat: ------------------ python/pyosaf/utils/immom/ccb.py | 56 +++++++++++++------------------------------ 1 files changed, 17 insertions(+), 39 deletions(-) Testing Commands: ----------------- See the ticket for steps to verify the fault and the commit message for steps to verify the fix. Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
