Summary: pyosaf: Fix broken marshalling in saImmOiRtObjectUpdate_2 in saImmOi.py [#1411] Review request for Trac Ticket(s): #1411 Peer Reviewer(s): [email protected], [email protected], [email protected], [email protected] Pull request to: [email protected] Affected branch(es): 4.2.x Development branch: opensaf-staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- changeset e580df54bba63562a82eacd0aa4acdf20b93b1cb Author: Johan Mårtensson <[email protected]> Date: Fri, 10 Jul 2015 15:25:41 +0200 pyosaf: Fix broken marshalling in saImmOiRtObjectUpdate_2 in saImmOi.py [#1411] Fix the broken marshalling of attribute modifications in saImmOiRtObjectUpdate_2 in saImmOi.py. This fix can be verified by copy- paste of the code below into a Python shell: from pyosaf.saAis import SaVersionT from pyosaf.saImmOi import SaImmOiImplementerNameT from pyosaf.saImmOi import saImmOiImplementerSet from pyosaf.saImm import SaImmClassNameT from pyosaf.saImm import eSaImmValueTypeT from pyosaf.saImm import SaImmAttrModificationT_2 from pyosaf.saImm import eSaImmAttrModificationTypeT from pyosaf.saImm import SaImmAttrValuesT_2 from pyosaf.saImm import SaImmAttrNameT from pyosaf.utils.immom.ccb import marshal_c_array from pyosaf.saImmOi import SaImmOiHandleT from pyosaf.saImmOi import saImmOiInitialize_2 from pyosaf.saImmOi import saImmOiRtObjectUpdate_2 from pyosaf.saAis import SaNameT version = SaVersionT('A', 2, 11) HANDLE = SaImmOiHandleT() err = saImmOiInitialize_2(HANDLE, None, version) impl_name = SaImmOiImplementerNameT('some_impl') err = saImmOiImplementerSet(HANDLE, impl_name) c_class_name = SaImmClassNameT('AnyClass') attr_mods = [] attributes = {'a' : 'value'} attr_type = eSaImmValueTypeT.SA_IMM_ATTR_SASTRINGT c_attr_mod = SaImmAttrModificationT_2() c_attr_mod.modType = eSaImmAttrModificationTypeT.SA_IMM_ATTR_VALUES_REPLACE c_attr_mod.modAttr = SaImmAttrValuesT_2() c_attr_mod.modAttr.attrName = SaImmAttrNameT('anyAttribute') _attr_mod.modAttr.attrValueType = attr_type c_attr_mod.modAttr.attrValuesNumber = 1 c_attr_mod.modAttr.attrValues = marshal_c_array(attr_type, ['sdf']) attr_mods.append(c_attr_mod) err = saImmOiRtObjectUpdate_2(HANDLE, SaNameT('anyObject=2'), attr_mods) Complete diffstat: ------------------ python/pyosaf/saImmOi.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Testing Commands: ----------------- See the commit message for how to reproduce the fault and verify the fix. Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
