Summary: amfd: maintain runtime updates for su, comp, si and csi at standby
[#1141]
Review request for Trac Ticket(s): #1141
Peer Reviewer(s): Hans N,. Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset a7418d27dc8eb07287db382cb94d4e60fe7c2ce6
Author: praveen.malv...@oracle.com
Date: Fri, 31 Jul 2015 18:01:55 +0530
amfd: maintain runtime updates for su, comp, si and csi at standby
[#1141]
Amfd was killed when lock operation on su was going on. After successful
failover, susi of locked su is still shown.
In the reported issue, lock operation was successful and active AMFD was
able to delete SUSIs and COMPCSIs in its database before got killed.
AMFD
was killed when it was performing run time updates for su, comp, si and
csi
to imm. SUSI and COMPCSI of locked Su is still shown because active
AMFD was
killed without performing all the updates and since these updates are
not
maintained at standby AMFD, even after failover imm was not updated for
the
same.
Patch proposes a solution, in which standby AMFD will maintain run time
updates for su, comp, si and csi. However the size of the job queue
will not
execeed more that 200. Job queue will be emptied at standby if it
crosses
this max size limit. The value of 200 is taken from the reproted issue
in
which AMFD missed around 150 updates to imm for comp, su, csi and csi
during
failover.
TODO: This solution has following limitations: 1)Fix size(200) of job
queue
at standby. 2)Standby maintains updates for only su,comp, csi and si.
3)New
active may still miss some updates if updates are more than 200.
Improved solution will be something like this: 1)Standby AMFD will
maintain
updates for all the classes and with no size limitation. 2)Whenever
active
controller is finished updating to imm and there are no more jobs to
update,
it will ask standby AMFD to flush its job queue.
Implementaion of this will require new messaging (AMFD version update)
and
thus will be backward incompatible.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 10 ++++++++++
osaf/services/saf/amf/amfd/csi.cc | 3 ---
osaf/services/saf/amf/amfd/imm.cc | 53
+++++++++++++++++++++++++++++++++++++++++++++++++----
osaf/services/saf/amf/amfd/include/imm.h | 2 ++
osaf/services/saf/amf/amfd/siass.cc | 9 ---------
5 files changed, 61 insertions(+), 16 deletions(-)
Testing Commands:
-----------------
Tested as per ticket description.
Testing, Expected Results:
--------------------------
standby AMFD updates IMM and user will not see SUSI and compcsi of locked SU.
Conditions of Submission:
-------------------------
Ack from atleast oner reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
