Summary: log: Create runtime object to display log configuration
Review request for Trac Ticket(s): #1393
Peer Reviewer(s): mathi.naic...@oracle.com
Pull request to: -
Affected branch(es): devel
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 0d69184e38e7c510c6fdf1ced4846ea74b001b9f
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Mon, 10 Aug 2015 15:49:10 +0200
log: Create runtime object to display log configuration [#1393]
Create a runtime object to make it possible to see the actual
configuration.
Configuration may come from three sources; configuration object,
environment
variables or hard coded default values; This handling is dependent on
that a
runtime class is predefined. No runtime object will be created if no
runtime
class is defined
Added Files:
------------
tests/logsv/tet_log_runtime_cfgobj.c
Complete diffstat:
------------------
osaf/services/saf/logsv/README | 58 ++++++++++++++++++----
osaf/services/saf/logsv/config/logsv_classes.xml | 59 ++++++++++++++++++++++
osaf/services/saf/logsv/lgs/lgs_config.c | 198
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
osaf/services/saf/logsv/lgs/lgs_config.h | 19 +++++++
osaf/services/saf/logsv/lgs/lgs_evt.c | 4 -
osaf/services/saf/logsv/lgs/lgs_filehdl.c | 2 +-
osaf/services/saf/logsv/lgs/lgs_imm.c | 109
+++++++++++++++++++++++------------------
osaf/services/saf/logsv/lgs/lgs_main.c | 5 +
osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 3 +-
osaf/services/saf/logsv/lgs/lgs_mbcsv_v5.c | 17 +++---
tests/logsv/Makefile.am | 3 +-
tests/logsv/logtest.h | 3 +
tests/logsv/tet_log_runtime_cfgobj.c | 105
++++++++++++++++++++++++++++++++++++++++
13 files changed, 484 insertions(+), 101 deletions(-)
Testing Commands:
-----------------
1.
# logtest
2.
# immlist logConfig=2,safApp=safLogService
Testing, Expected Results:
--------------------------
1.
All tests shall PASS including new suite 8
2.
Name Type Value(s)
========================================================================
logStreamSystemLowLimit SA_UINT32_T 0 (0x0)
logStreamSystemHighLimit SA_UINT32_T 0 (0x0)
logStreamAppLowLimit SA_UINT32_T 0 (0x0)
logStreamAppHighLimit SA_UINT32_T 0 (0x0)
logRootDirectory SA_STRING_T
/repl_opensaf/saflog
logMaxLogrecsize SA_UINT32_T 1024 (0x400)
logMaxApplicationStreams SA_UINT32_T 64 (0x40)
logFileSysConfig SA_UINT32_T 1 (0x1)
logFileIoTimeout SA_UINT32_T 500 (0x1f4)
logDataGroupname SA_STRING_T
logConfig SA_STRING_T logConfig=2
SaImmAttrImplementerName SA_STRING_T safLogService
SaImmAttrClassName SA_STRING_T
OpenSafLogConfigRuntime
SaImmAttrAdminOwnerName SA_STRING_T <Empty>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
