Summary: amfd: Convert AVD_AVND list_of_ncs_su and list_of_ncs_su to std::vector
Review request for Trac Ticket(s): #1142
Peer Reviewer(s): Nagu, Praveen, Gary
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please apply this patch on top of previous sent out avd_comp_1142 -
avd_sutype_1142 (10 patches).
changeset 33f283b18230982c121a1b80e8ab2c25bb6416d3
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Fri, 21 Aug 2015 15:10:11 +0200
amfd: Convert AVD_AVND list_of_ncs_su and list_of_ncs_su to std::vector
[#1142]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/ckpt_dec.cc | 2 +-
osaf/services/saf/amf/amfd/clm.cc | 12 +--
osaf/services/saf/amf/amfd/include/node.h | 27 +------
osaf/services/saf/amf/amfd/include/su.h | 1 -
osaf/services/saf/amf/amfd/main.cc | 3 +-
osaf/services/saf/amf/amfd/ndfsm.cc | 15 +---
osaf/services/saf/amf/amfd/ndproc.cc | 7 +-
osaf/services/saf/amf/amfd/node.cc | 161
+++++++++++++++------------------------------
osaf/services/saf/amf/amfd/nodegroup.cc | 31 +++-----
osaf/services/saf/amf/amfd/nodeswbundle.cc | 5 +-
osaf/services/saf/amf/amfd/role.cc | 6 +-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 21 +----
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 27 ++-----
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 28 ++-----
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 39 ++++------
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 25 ++----
osaf/services/saf/amf/amfd/sgproc.cc | 56 ++++-----------
osaf/services/saf/amf/amfd/su.cc | 5 +-
osaf/services/saf/amf/amfd/util.cc | 4 +-
19 files changed, 152 insertions(+), 323 deletions(-)
Testing Commands:
-----------------
Run the amf demo in uml
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
