Summary: log: saflogger does not check invalid options [#1367]
Review request for Trac Ticket(s): 1367
Peer Reviewer(s): [email protected], [email protected],
[email protected]
Pull request to: Lennart
Affected branch(es): 4.5, 4.6, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset f07f1f97758d8a576620b83eeae23d9a6573d1d8
Author: Giang
Date: Thu, 02 Jul 2015 13:14:38 +0700
log: saflogger does not check invalid options [#1367]
If there are invalid non-options, show them, recommend use --help and
then
exit.
Complete diffstat:
------------------
osaf/tools/saflog/saflogger/saf_logger.c | 49
+++++++++++++++++++++++++++++++++++--------------
1 files changed, 35 insertions(+), 14 deletions(-)
Testing Commands:
-----------------
saflogger -a safLgStrCfg=Test "Hello world"
saflogger -a safLgStrCfg=Test "Hello world" abc
saflogger -h
Testing, Expected Results:
--------------------------
root@SC-1:~# saflogger -a safLgStrCfg=Test "Hello world"
root@SC-1:~# saflogger -a safLgStrCfg=Test "Hello world" abc
Invalid argument.
Enclose message in quotation marks "" e.g. "Hello world abc"
Try saflogger -h for more information.
root@SC-1:~# saflogger -h
NAME
saflogger - write log record to log stream
SYNOPSIS
saflogger [options] [message ...]
DESCRIPTION
saflogger is a SAF LOG client used to write a log record into a
specified log stream.
OPTIONS
-h or --help this help
-l or --alarm write to alarm stream
-n or --notification write to notification stream
-y or --system write to system stream (default)
-a NAME or --application=NAME write to application stream NAME
(create it if not exist)
-s SEV or --severity=SEV use severity SEV, default INFO
valid severity names: emerg, alert, crit, error, warn,
notice, info
EXAMPLES
saflogger -a safLgStrCfg=Test "Hello world"
saflogger -s crit "I am going down"
Conditions of Submission:
-------------------------
Ack from peer reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
