Summary: amfd: Don't send alarm SI has no current active assignments if node is locked V3 Review request for Trac Ticket(s): #1465 Peer Reviewer(s): Nagu, Praveen, Gary Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 5f4e62ce893b785dfb2b02a5bb456079891f9b3e Author: Hans Nordeback <[email protected]> Date: Thu, 10 Sep 2015 08:22:15 +0200 amfd: Don't send alarm SI has no current active assignments if node is locked V3 [#1465] To perform scalein, shutdown is performed on a nodegroup. No-red application SI's are receiving alarm "SI has no current active assignments" which is not wanted at scalein. Thereafter OpenSAF is stopped via opensafd stop, the M/W No-red SI's are receiving "SI has no current active assignments" which is not wanted at scalein. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/si.h | 2 ++ osaf/services/saf/amf/amfd/si.cc | 22 ++++++++++++++++++---- osaf/services/saf/amf/amfd/siass.cc | 3 +++ 3 files changed, 23 insertions(+), 4 deletions(-) Testing Commands: ----------------- 1) Configure AmfDemo app as no-red on e.g. PL-3 and PL-4. 2) on SC-2 ntfsubscribe -a 3) amf-adm unlock-in safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1 amf-adm unlock-in safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1 amf-adm unlock safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1 amf-adm unlock safSu=SU2,safSg=AmfDemo,safApp=AmfDemo1 4) create new nodegroup and add node to nodeList immcfg -c 'SaAmfNodeGroup' safAmfNodeGroup=scale_in_shutdown,safAmfCluster=myAmfCluster -a saAmfNGNodeList=safAmfNode=PL-3,safAmfCluster=myAmfCluster immcfg safAmfNodeGroup=scale_in_shutdown,safAmfCluster=myAmfCluster -a saAmfNGNodeList+=safAmfNode=PL-4,safAmfCluster=myAmfCluster immcfg safAmfNodeGroup=scale_in_shutdown,safAmfCluster=myAmfCluster -a saAmfNGNodeList+=safAmfNode=PL-5,safAmfCluster=myAmfCluster 5) shutdown, no unassigned alarms for no-red application SIs should be sent amf-adm shutdown safAmfNodeGroup=scale_in_shutdown,safAmfCluster=myAmfCluster 6) remove node group immcfg -d safAmfNodeGroup=scale_in_shutdown,safAmfCluster=myAmfCluster 7) lock-in e.g. PL-3 amf-adm lock-in safAmfNode=PL-3,safAmfCluster=myAmfCluster 8) on PL-3, no unassigned alarms for M/W no-red application SIs should be sent /etc/init.d/opensafd stop Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
