Summary: amfd: mark NG locked if controller failovers during shutdown op on NG [#1513] Review request for Trac Ticket(s): #1513 Peer Reviewer(s): Hans N., Nagendra, Gary Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): Default, 4.7 and 4.6 Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset d3cfdf2aee5abf24c5ac6bfb16b6fd044befc5f5 Author: [email protected] Date: Mon, 05 Oct 2015 16:14:03 +0530 amfd: mark NG locked if controller failovers during shutdown op on NG [#1513] NG gets stuck in SHUTTING_DOWN state during shutdown op and controller failover. During SHUTDOWN admin operation on NG, initial admin state is set to SHUTTING_DOWN and it is checkpointed to standby AMFD. On decoding it, standby AMFD sets node->admin_ng and it clears it when active AMFD checkpoints the LOCKED state. Now after fail-over when AMFD gets quiescing success response from AMFND it clears this pointer in process_su_si_response_for_ng() assuming there is only one SU hosted on that node. After this when response for second SU comes, this response is not processed from NG perspective as AMFD has already cleared node->admin_ng. Issue does not occur when node hosts only one application SU. Patch fixes the problem by avoiding clearing of node->admin_ng when NG is in SHUTTING_DOWN state. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sgproc.cc | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) Testing Commands: ----------------- Tested with steps given in the ticket. Testing, Expected Results: -------------------------- NodeGroup is finally marked LOCKED. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
