Summary: log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466]
Review request for Trac Ticket(s): #1466
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com;
giang.t...@dektech.com.au
Pull request to: Lennart
Affected branch(es): All branches
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset 7218fab526b8b239cc6f9354580102c7dd958056
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Fri, 02 Oct 2015 09:57:57 +0100
log: fix crashed with saLogStreamFixedLogRecordSize=1 [#1466]
The mininum value should be 150 if not 0 as the log record with no
information is meaningless.
Also validate if the value is in range for runtime stream which created
via
LOG API.
Complete diffstat:
------------------
osaf/libs/agents/saf/lga/lga_api.c | 8 ++++++++
osaf/libs/saf/include/saLog.h | 4 ++++
osaf/services/saf/logsv/lgs/lgs_config.c | 3 ++-
osaf/services/saf/logsv/lgs/lgs_evt.c | 9 +++++++++
osaf/services/saf/logsv/lgs/lgs_imm.c | 7 +++++++
osaf/tools/saflog/saflogger/saf_logger.c | 2 +-
tests/logsv/logtest.h | 2 +-
tests/logsv/saflogtest.c | 2 +-
tests/logsv/tet_LogOiOps.c | 24 +++++++++++++++++++++---
tests/logsv/tet_saLogStreamOpen_2.c | 104
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
10 files changed, 158 insertions(+), 7 deletions(-)
Testing Commands:
-----------------
Following test cases added, use them to test this patch.
logtest 2 48
logtest 2 49
logtest 6 33
Note: to run all test cases in one go, make sure update saflogger/saflogtest
apps
before running logtest as the allowed minimum fixedLogRec now is 150 if not
zero (0).
Testing, Expected Results:
--------------------------
All tests PASS
Conditions of Submission:
-------------------------
Get ack from peer reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Full-scale, agent-less Infrastructure Monitoring from a single dashboard
Integrate with 40+ ManageEngine ITSM Solutions for complete visibility
Physical-Virtual-Cloud Infrastructure monitoring from one console
Real user monitoring with APM Insights and performance trend reports
Learn More http://pubads.g.doubleclick.net/gampad/clk?id=247754911&iu=/4140
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
