Summary: amfd: fix SU presence state transition during restart admin op v2
[#1518]
Review request for Trac Ticket(s): #1518
Peer Reviewer(s): Hans , Nagendra, Quyen
Pull request to: Nagendra.
Affected branch(es): Default and 4.7
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Fixed AMFND crash.
changeset c9fd630a561cd1a03698845c046f8ab9ab18e2e5
Author: praveen.malv...@oracle.com
Date: Wed, 21 Oct 2015 18:03:49 +0530
amfd: fix SU presence state transition during restart admin op [#1518]
Note:Issue is valid for a restartable SU only.
When RESTART operation is invoked on a restartable SU, its presence
state
transtions: INSTANTIATED => RESTARTING => INSTANTIATING => INSTANTIATED.
which is incorrect as per AIS-AMF-B.04.01-Table 5 Page 74.
At present, when all the components are in RESTARTING state, SU is
marked as
RESTARTING. As soon as AMF starts instantiating first comp by keeping
it in
RESTARTING state, AMF is marking SU INSTANTIATING. Here AMF must wait
for
the instantiation of component and should not mark SU INSTANTIATING.
When
first comp gets successfully instantiated, AMF imust mark first comp
INSTANTIATED and SU will also be marked INSTANTIATED as per AIS-
AMF-B.04.01-Table 5 Page 74.
Patch fixes the problem by marking the SU INSTANTIATED as soons as first
component enters into INSTANTIATED state. During the instantiation of
other
components, SU will remain in INSTANTIATED state. AMF will reply to IMM
for
the operation when all the components enters into INSTATANTIATED state.
changeset a905c037612bf5afd60baa2b5f9ca3dcd36af95e
Author: praveen.malv...@oracle.com
Date: Wed, 21 Oct 2015 18:04:14 +0530
amfd: add member function for accessing surestart [#1518]
This patch adds member functions to access su->surestart.This was a
minor
comment on #315 (for amfd code) given by Hans N. It will be pushed only
in
default branch.
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/comp.cc | 18 ++++-
osaf/services/saf/amf/amfd/include/comp.h | 1 +
osaf/services/saf/amf/amfd/include/su.h | 8 ++-
osaf/services/saf/amf/amfd/ndproc.cc | 24 +++++---
osaf/services/saf/amf/amfd/sgproc.cc | 6 +-
osaf/services/saf/amf/amfd/su.cc | 34 ++++++++++-
osaf/services/saf/amf/amfnd/clc.cc | 5 +-
osaf/services/saf/amf/amfnd/include/avnd_su.h | 2 +
osaf/services/saf/amf/amfnd/su.cc | 11 ++++
osaf/services/saf/amf/amfnd/susm.cc | 165
++++++++++++++++++++++++++++++++++++++++++++---------------
10 files changed, 205 insertions(+), 69 deletions(-)
Testing Commands:
-----------------
Tested NPI
will test PI and Mix also.
Testing, Expected Results:
--------------------------
No crash for NPI.
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
