Hi Long, patch is now pushed/Thanks HansN On 11/12/2015 01:30 PM, Long Nguyen wrote: > Hi Hans, > > Can you please also push the code for AMFND? Thanks so much. > > Best regards, > Long Nguyen. > > On 10/27/2015 7:09 PM, Hans Nordebäck wrote: >> Ack for the series, code review only/Thanks HansN >> >> -----Original Message----- >> From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au] >> Sent: den 20 oktober 2015 11:58 >> To: Hans Nordebäck; Gary Lee; praveen.malv...@oracle.com; >> nagendr...@oracle.com >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: [PATCH 00 of 30] Review Request for amfnd: convert NULL to >> nullptr [#1551] >> >> Summary: amfnd: convert NULL to nullptr [#1551] Review request for >> Trac Ticket(s): [#1551] Peer Reviewer(s): Hans, Gary, Praveen, Nagu >> Pull request to: Hans Affected branch(es): default Development >> branch: default >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset d9e5204b9cd64449385835be326c4635993233ca >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:08:29 +0700 >> >> amfnd: convert NULL to nullptr for amfnd.cc [#1551] >> >> changeset 4aa0c0e69ea683b655e5ce95a48bd46668bb1947 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:13:52 +0700 >> >> amfnd: convert NULL to nullptr for cbq.cc [#1551] >> >> changeset 8565a4b0f13090e2a248d4dc030107fe872c46e3 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:16:24 +0700 >> >> amfnd: convert NULL to nullptr for chc.cc [#1551] >> >> changeset 61e799adaa100457d5da11741daab89abb312342 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:20:01 +0700 >> >> amfnd: convert NULL to nullptr for ckpt_dec.cc [#1551] >> >> changeset 6146e7b22e233213be199892f03f8f2b87e7733a >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:22:03 +0700 >> >> amfnd: convert NULL to nullptr for ckpt_edu.cc [#1551] >> >> changeset 3010ccff64a8b80f0b0ba2abeee3c3f569c06a36 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:23:20 +0700 >> >> amfnd: convert NULL to nullptr for ckpt_enc.cc [#1551] >> >> changeset 19fff7f26c302b0a252c537979c5be117a96b8ab >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:24:52 +0700 >> >> amfnd: convert NULL to nullptr for ckpt_updt.cc [#1551] >> >> changeset 58263076e522c0494bd91480001a68369818b0c9 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:26:02 +0700 >> >> amfnd: convert NULL to nullptr for clc.cc [#1551] >> >> changeset ec0d86a8fcac950de12157c90406e1c60a688cc0 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:27:11 +0700 >> >> amfnd: convert NULL to nullptr for clm.cc [#1551] >> >> changeset 6f24ab6b30da4a901bff37e3c65f628e478505d9 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:28:06 +0700 >> >> amfnd: convert NULL to nullptr for comp.cc [#1551] >> >> changeset 114de32db084f1987a80fa450509619455702054 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:29:43 +0700 >> >> amfnd: convert NULL to nullptr for compdb.cc [#1551] >> >> changeset 1351acca1f39d71e0d084a7bdb156d8168b73b16 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:42:44 +0700 >> >> amfnd: convert NULL to nullptr for cpm.cc [#1551] >> >> changeset e850274601d9d382839c2538381c98b8151f08a2 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:43:26 +0700 >> >> amfnd: convert NULL to nullptr for di.cc [#1551] >> >> changeset 6f75b3025f9d26fee62aa3e1e92750e86a9e596c >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:45:17 +0700 >> >> amfnd: convert NULL to nullptr for err.cc [#1551] >> >> changeset 92a13233ca950df369ca41ab9d5241c815fe3bc3 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:46:49 +0700 >> >> amfnd: convert NULL to nullptr for evt.cc [#1551] >> >> changeset 913ca62cb17743d241dda8672bcfc22773c3aae3 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:47:43 +0700 >> >> amfnd: convert NULL to nullptr for hcdb.cc [#1551] >> >> changeset d18406ea8012bd153f83550b3a1c893996fe2d54 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:48:39 +0700 >> >> amfnd: convert NULL to nullptr for main.cc [#1551] >> >> changeset 228c017ee533cc9a3d8aae0badc7a748b7f42584 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:50:13 +0700 >> >> amfnd: convert NULL to nullptr for mbcsv.cc [#1551] >> >> changeset d6d3d5b4aa2a9c4ac41d9cfb6953ac2c6428200e >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:51:32 +0700 >> >> amfnd: convert NULL to nullptr for mds.cc [#1551] >> >> changeset d1bf0e5468fd8908aa50273cb0b468d27f756ee7 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:52:13 +0700 >> >> amfnd: convert NULL to nullptr for mon.cc [#1551] >> >> changeset c1dd617127604017f920b54bb2f3cd031ea66887 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:53:13 +0700 >> >> amfnd: convert NULL to nullptr for pg.cc [#1551] >> >> changeset 873947fc8c5a5de04ef0e8725428f13d7a2e0be1 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:55:57 +0700 >> >> amfnd: convert NULL to nullptr for proxy.cc [#1551] >> >> changeset 6a1e7cdb12e7fe769fc754b6f0fef64b9b9a6847 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:57:25 +0700 >> >> amfnd: convert NULL to nullptr for proxydb.cc [#1551] >> >> changeset 5697c5d1fdab0065cd39faeb86a4ea15df54e696 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:58:39 +0700 >> >> amfnd: convert NULL to nullptr for sidb.cc [#1551] >> >> changeset cd1d8f4cb46866a69188ff3a269b4e9e61a2e3a4 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 14:59:54 +0700 >> >> amfnd: convert NULL to nullptr for su.cc [#1551] >> >> changeset 8e0e2c8c8b5f48ae1ff5fd609fff536d73bb36aa >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 15:01:48 +0700 >> >> amfnd: convert NULL to nullptr for susm.cc [#1551] >> >> changeset 7aa5d23c5533abc88a2725b038056f1ec4880ce0 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 15:02:24 +0700 >> >> amfnd: convert NULL to nullptr for term.cc [#1551] >> >> changeset f795068fb5eeed0e3395c222a0cce70a947b6e13 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 15:03:46 +0700 >> >> amfnd: convert NULL to nullptr for util.cc [#1551] >> >> changeset 18cac595a5a5ec1c202c366dbea5d88888f45054 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 15:04:38 +0700 >> >> amfnd: convert NULL to nullptr for verify.cc [#1551] >> >> changeset db0de44cc8fef9a868cf0fe9bd6cc009a9972c40 >> Author: Long HB Nguyen<long.hb.ngu...@dektech.com.au> >> Date: Tue, 20 Oct 2015 16:30:13 +0700 >> >> amfnd: convert NULL to nullptr for avnd_comp.h [#1551] >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/amf/amfnd/amfnd.cc | 36 >> ++++++++-------- >> osaf/services/saf/amf/amfnd/cbq.cc | 16 +++--- >> osaf/services/saf/amf/amfnd/chc.cc | 14 +++--- >> osaf/services/saf/amf/amfnd/ckpt_dec.cc | 396 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------------------------------------------- >> osaf/services/saf/amf/amfnd/ckpt_edu.cc | 296 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------ >> osaf/services/saf/amf/amfnd/ckpt_enc.cc | 22 ++++---- >> osaf/services/saf/amf/amfnd/ckpt_updt.cc | 134 >> +++++++++++++++++++++++++++++----------------------------- >> osaf/services/saf/amf/amfnd/clc.cc | 28 ++++++------ >> osaf/services/saf/amf/amfnd/clm.cc | 14 +++--- >> osaf/services/saf/amf/amfnd/comp.cc | 60 >> +++++++++++++------------- >> osaf/services/saf/amf/amfnd/compdb.cc | 104 >> +++++++++++++++++++++++----------------------- >> osaf/services/saf/amf/amfnd/cpm.cc | 4 +- >> osaf/services/saf/amf/amfnd/di.cc | 2 +- >> osaf/services/saf/amf/amfnd/err.cc | 4 +- >> osaf/services/saf/amf/amfnd/evt.cc | 2 +- >> osaf/services/saf/amf/amfnd/hcdb.cc | 28 ++++++------ >> osaf/services/saf/amf/amfnd/include/avnd_comp.h | 14 +++--- >> osaf/services/saf/amf/amfnd/main.cc | 8 +- >> osaf/services/saf/amf/amfnd/mbcsv.cc | 28 ++++++------ >> osaf/services/saf/amf/amfnd/mds.cc | 30 ++++++------ >> osaf/services/saf/amf/amfnd/mon.cc | 8 +- >> osaf/services/saf/amf/amfnd/pg.cc | 12 ++-- >> osaf/services/saf/amf/amfnd/proxy.cc | 16 +++--- >> osaf/services/saf/amf/amfnd/proxydb.cc | 20 ++++---- >> osaf/services/saf/amf/amfnd/sidb.cc | 32 +++++++------- >> osaf/services/saf/amf/amfnd/su.cc | 28 ++++++------ >> osaf/services/saf/amf/amfnd/susm.cc | 106 >> +++++++++++++++++++++++----------------------- >> osaf/services/saf/amf/amfnd/term.cc | 6 +- >> osaf/services/saf/amf/amfnd/util.cc | 24 +++++----- >> osaf/services/saf/amf/amfnd/verify.cc | 4 +- >> 30 files changed, 748 insertions(+), 748 deletions(-) >> >> >> Testing Commands: >> ----------------- >> Run AmfDemo (2N, NWay-Active) >> >> >> Testing, Expected Results: >> -------------------------- >> AmfDemo runs without errors >> >> >> Conditions of Submission: >> ------------------------- >> <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 y y >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank >> entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your >> headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be >> pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear >> indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial >> review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> >> >
------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
