Hi Praveen,

ACK with a couple of comments(leaving it up to you):

You could consider changing the log string to something like
logger -t $prog "amfnd has not yet exited(stuck?), killing forcibly"

b.t.w, Did you consider avoiding the kill of amfnd here because final_clean
will anyway trigger the reboot!? Or may be not, because by killing amfnd, the 
reboot is done via opensaf_reboot script which is good!. 



Thanks,
Mathi.

----- praveen.malv...@oracle.com wrote:

> osaf/services/infrastructure/nid/scripts/opensafd.in |  4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> 
> During opensaf shutdown phase, if amfnd does not exit in configure
> OPENSAF_TERMTIMEOUT, then
> kill amfnd process after timeout.
> 
> diff --git a/osaf/services/infrastructure/nid/scripts/opensafd.in
> b/osaf/services/infrastructure/nid/scripts/opensafd.in
> --- a/osaf/services/infrastructure/nid/scripts/opensafd.in
> +++ b/osaf/services/infrastructure/nid/scripts/opensafd.in
> @@ -254,6 +254,10 @@ stop() {
>                       timeout=$((timeout-1))
>               done
>               [ -d /proc/$amfpid ] && RETVAL=1
> +             if [ $RETVAL -eq 1 ]; then
> +                     logger -t $prog "amfnd not exited, killing its process"
> +                     kill -9 $amfpid 
> +             fi
>       else
>               pkill -9 osaf* >/dev/null 2>&1
>       fi

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to