Hi Ramesh! Do you have any comments on this review?
regards, Anders Widell On 12/10/2015 11:38 AM, Anders Widell wrote: > Summary: Simplify osaf_nanosleep() and add new time constants > Review request for Trac Ticket(s): 777 > Peer Reviewer(s): Ramesh, Hans > Pull request to: > Affected branch(es): default(5.0) > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services n > Core libraries y > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 155811ee709c47e0a6feadf8e859a2e8371d7820 > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 10 Dec 2015 11:24:56 +0100 > > base: Add missing #ifdef around _GNU_SOURCE macro definition [#777] > > changeset 4e93d53c9faacf87a514a5e4196c8005c0ec831f > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 10 Dec 2015 11:25:05 +0100 > > base: Simplify osaf_nanosleep() and add new time constants [#777] > > Simplify osaf_nanosleep() by using clock_nanosleep() instead of > nanosleep(). > Also add commonly used time constants to the header file. > > changeset f05612c976f15a3601d2b07f404a2ea4aee2d433 > Author: Anders Widell <anders.wid...@ericsson.com> > Date: Thu, 10 Dec 2015 11:25:12 +0100 > > base: Add unit tests for osaf_time.c [#777] > > > Complete diffstat: > ------------------ > configure.ac | 1 + > osaf/libs/core/common/Makefile.am | 2 +- > osaf/libs/core/common/include/osaf_secutil.h | 4 +- > osaf/libs/core/common/include/osaf_time.h | 13 ++++- > osaf/libs/core/common/osaf_time.c | 51 > +++++++---------- > osaf/libs/core/common/tests/Makefile.am | 51 > +++++++++++++++++ > osaf/libs/core/common/tests/mock_clock_gettime.cc | 45 > +++++++++++++++ > osaf/libs/core/common/tests/mock_clock_gettime.h | 33 > +++++++++++ > osaf/libs/core/common/tests/mock_clock_nanosleep.cc | 66 > +++++++++++++++++++++++ > osaf/libs/core/common/tests/mock_clock_nanosleep.h | 33 > +++++++++++ > osaf/libs/core/common/tests/mock_syslog.cc | 23 ++++++++ > osaf/libs/core/common/tests/mock_syslog.h | 23 ++++++++ > osaf/libs/core/common/tests/osaf_clock_gettime_test.cc | 73 > +++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_nanosleep_test.cc | 81 > ++++++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_normalize_timespec_test.cc | 81 > ++++++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_time_test.cc | 390 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_timespec_add_test.cc | 62 > +++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_timespec_compare_test.cc | 75 > ++++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_timespec_convert_test.cc | 100 > +++++++++++++++++++++++++++++++++++ > osaf/libs/core/common/tests/osaf_timespec_subtract_test.cc | 62 > +++++++++++++++++++++ > 20 files changed, 1236 insertions(+), 33 deletions(-) > > > Testing Commands: > ----------------- > * Download Googletest from https://github.com/google/googletest > * Cd to the googletest folder and run: autoreconf -vi; ./configure; make > * export GTEST_DIR=`pwd` > * go to the opensaf repo and run "make check" > > Testing, Expected Results: > -------------------------- > All added unit tests shall pass > > > Conditions of Submission: > ------------------------- > Ack from reviewer(s) > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 y n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
