Hi,
Please review, I would prefer to push it today.
Thanks
-Nagu
> -----Original Message-----
> From: Nagendra Kumar
> Sent: 18 April 2016 10:37
> To: Praveen Malviya; hans.nordeb...@ericsson.com;
> gary....@dektech.com.au; minh.c...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 0 of 1] Review Request for amfnd: do not invoke
> health check command when npi comp is TERMINATING [#1759]
>
> Please review.
>
> Thanks
> -Nagu
>
> > -----Original Message-----
> > From: Praveen Malviya
> > Sent: 14 April 2016 15:08
> > To: hans.nordeb...@ericsson.com; Nagendra Kumar;
> > gary....@dektech.com.au; minh.c...@dektech.com.au
> > Cc: opensaf-devel@lists.sourceforge.net
> > Subject: [PATCH 0 of 1] Review Request for amfnd: do not invoke health
> > check command when npi comp is TERMINATING [#1759]
> >
> > Summary: do not invoke health check command when npi comp is
> > TERMINATING [#1759] Review request for Trac Ticket(s): #1759 Peer
> > Reviewer(s): AMF devs Pull request to: <<LIST THE PERSON WITH PUSH
> > ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY
> > GIVE THE REPO URL>>
> >
> > --------------------------------
> > Impacted area Impact y/n
> > --------------------------------
> > Docs n
> > Build system n
> > RPM/packaging n
> > Configuration files n
> > Startup scripts n
> > SAF services y
> > OpenSAF services n
> > Core libraries n
> > Samples n
> > Tests n
> > Other n
> >
> >
> > Comments (indicate scope for each "y" above):
> > ---------------------------------------------
> >
> > changeset e9a4b6f1534e9947719fb8f14987089c777ed6ea
> > Author: praveen.malv...@oracle.com
> > Date: Thu, 14 Apr 2016 15:01:36 +0530
> >
> > amfnd: do not invoke health check command when npi comp is
> > TERMINATING
> > [#1759]
> >
> > In the reported problem Command Based HC was invoked for a NPI
> > component in
> > termination phase.
> >
> > Before terminating/cleaning up a NPI comp, AMFND stops timer for
> > periodically invoking command based health check for it. At the time
> > of
> > launching TERMINATE/CLEANUP command, if already invoked
> Health Check
> > command
> > is in progress then its response may come during the termination
> > phase and
> > AMFND may start timer for invoking the command again.
> >
> > If comp is not found instantiated then do not start health check timer
> > again. Exit status of any pending Terminate/cleanup scripts will take
> > care
> > of comp's fault management.
> >
> >
> > Complete diffstat:
> > ------------------
> > osaf/services/saf/amf/amfnd/chc.cc | 13 +++++++++++++
> > 1 files changed, 13 insertions(+), 0 deletions(-)
> >
> >
> > Testing Commands:
> > -----------------
> > Tested with the configuration given in the ticket description.
> >
> > Testing, Expected Results:
> > --------------------------
> > When HC command response comes, AMFND simply logs and does not
> start
> > timer again.
> >
> > Apr 14 14:44:58.979410 osafamfnd [10851:main.cc:0627] TR Evt type:49
> > Apr
> > 14 14:44:58.979419 osafamfnd [10851:clc.cc:0314] >>
> > avnd_evt_clc_resp_evh Apr 14 14:44:58.979429 osafamfnd
> > [10851:clc.cc:0325] TR
> > 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1',
> > command type:AVND_COMP_CLC_CMD_TYPE_HC(6) Apr 14
> > 14:44:58.979437 osafamfnd [10851:chc.cc:0764] >> find_hc_rec:
> > 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1'
> > Apr 14 14:44:58.979445 osafamfnd [10851:chc.cc:0803] T1
> > 'safComp=AmfDemo,safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1' not
> > instantiated, not starting Command based HC timer Apr 14
> > 14:44:58.979454 osafamfnd [10851:clc.cc:0417] <<
> > avnd_evt_clc_resp_evh: 1 Apr 14
> > 14:44:58.979461 osafamfnd [10851:main.cc:0633] TR Evt Type:49 success
> >
> >
> > Conditions of Submission:
> > -------------------------
> > Ack from any reviewer.
> >
> > Arch Built Started Linux distro
> > -------------------------------------------
> > mips n n
> > mips64 n n
> > x86 n n
> > x86_64 y y
> > powerpc n n
> > powerpc64 n n
> >
> >
> > Reviewer Checklist:
> > -------------------
> > [Submitters: make sure that your review doesn't trigger any
> > checkmarks!]
> >
> >
> > Your checkin has not passed review because (see checked entries):
> >
> > ___ Your RR template is generally incomplete; it has too many blank entries
> > that need proper data filled in.
> >
> > ___ You have failed to nominate the proper persons for review and push.
> >
> > ___ Your patches do not have proper short+long header
> >
> > ___ You have grammar/spelling in your header that is unacceptable.
> >
> > ___ You have exceeded a sensible line length in your
> > headers/comments/text.
> >
> > ___ You have failed to put in a proper Trac Ticket # into your commits.
> >
> > ___ You have incorrectly put/left internal data in your comments/files
> > (i.e. internal bug tracking tool IDs, product names etc)
> >
> > ___ You have not given any evidence of testing beyond basic build tests.
> > Demonstrate some level of runtime or other sanity testing.
> >
> > ___ You have ^M present in some of your files. These have to be removed.
> >
> > ___ You have needlessly changed whitespace or added whitespace crimes
> > like trailing spaces, or spaces before tabs.
> >
> > ___ You have mixed real technical changes with whitespace and other
> > cosmetic code cleanup changes. These have to be separate commits.
> >
> > ___ You need to refactor your submission into logical chunks; there is
> > too much content into a single commit.
> >
> > ___ You have extraneous garbage in your review (merge commits etc)
> >
> > ___ You have giant attachments which should never have been sent;
> > Instead you should place your content in a public tree to be pulled.
> >
> > ___ You have too many commits attached to an e-mail; resend as threaded
> > commits, or place in a public tree for a pull.
> >
> > ___ You have resent this content multiple times without a clear indication
> > of what has changed between each re-send.
> >
> > ___ You have failed to adequately and individually address all of the
> > comments and change requests that were proposed in the initial review.
> >
> > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
> >
> > ___ Your computer have a badly configured date and time; confusing the
> > the threaded patch review.
> >
> > ___ Your changes affect IPC mechanism, and you don't present any results
> > for in-service upgradability test.
> >
> > ___ Your changes affect user manual and documentation, your patch series
> > do not contain the patch that updates the Doxygen manual.
> >
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications Manager
> Applications Manager provides deep performance insights into multiple tiers
> of your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Opensaf-devel mailing list
> Opensaf-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
