Summary: amfnd: mark SU RESTARTING in comp FSM during restart of comp(s)
[#1752]
Review request for Trac Ticket(s): #1752
Peer Reviewer(s): AMF devs
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): ALL
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset abdc0eeda3896e70c58a3714096a45fca2b29859
Author: praveen.malv...@oracle.com
Date: Fri, 22 Apr 2016 15:01:55 +0530
amfnd: mark SU RESTARTING in comp FSM during restart of comp(s) [#1752]
In reported problem, AMFD does not send state change notification for
1)SU
presence state change from INSTANTIATED to RESTARTING and 2)SU presence
state change from RESTARTING to INSTANTIATED when component restarts
due to
RESTART admin op on it or faults with comp-restart recovery.
As per AMF spec, presence state of SU will be RESTARTING when all of its
comp are in RESTARTING presence state. In this case when comp restarts
due
to fault or RESTART admin op on it, AMFND is not marking SU's presence
state
RESTARTING and SU remains in INSTANTIATED state. Since there is no
change in
presence state of SU, no state change notification for SU is sent.
Patch fixes the problem by marking SU's presence state to RESTARTING
when:
1)SU consists of a single restartable component and this comp restarts
due
to fault or RESTART admin op on it. 2)SU consists of all restartable
components and all these components faults simultaneously.
Complete diffstat:
------------------
osaf/services/saf/amf/amfnd/clc.cc | 85
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
osaf/services/saf/amf/amfnd/include/avnd_su.h | 1 +
osaf/services/saf/amf/amfnd/susm.cc | 2 +-
3 files changed, 86 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
Tested as per ticket description.
Will test more than one restartable comp in a SU.
Testing, Expected Results:
--------------------------
Reported issue passed and got the notifcations:
=== Apr 22 14:34:33 - State Change ===
eventType = SA_NTF_OBJECT_STATE_CHANGE
notificationObject = "safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1"
notifyingObject = "safApp=safAmfService"
notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.109 (0x6d)
additionalText = "Presence state of SU safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
changed"
sourceIndicator = SA_NTF_OBJECT_OPERATION
State ID = SA_AMF_PRESENCE_STATE
Old State: SA_AMF_PRESENCE_INSTANTIATED
New State: SA_AMF_PRESENCE_RESTARTING
=== Apr 22 14:34:33 - State Change ===
eventType = SA_NTF_OBJECT_STATE_CHANGE
notificationObject = "safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1"
notifyingObject = "safApp=safAmfService"
notificationClassId = SA_NTF_VENDOR_ID_SAF.SA_SVC_AMF.109 (0x6d)
additionalText = "Presence state of SU safSu=SU1,safSg=AmfDemo,safApp=AmfDemo1
changed"
sourceIndicator = SA_NTF_OBJECT_OPERATION
State ID = SA_AMF_PRESENCE_STATE
Old State: SA_AMF_PRESENCE_RESTARTING
New State: SA_AMF_PRESENCE_INSTANTIATED
Conditions of Submission:
-------------------------
Ack from any reiewer in three days.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
