Summary: cpd: To delete the existing IMM object and create a new one when cpd
creates a new checkpoint [#1765]
Review request for Trac Ticket(s): 1765
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default, 5.0, 4.7
Development branch: 5.0
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset faadfd151c3b994b1dbd88d4173109ad61e7ea50
Author: Nhat Pham <nhat.p...@dektech.com.au>
Date: Mon, 25 Apr 2016 10:15:18 +0700
cpd: To delete the existing IMM object and create a new one when cpd
creates a new checkpoint [#1765]
Problem:
-------- In case a failover happens while a checkpoint is being
unlinked, it
might causes an unfinished unlink operation (i.e the checkpoint IMM
object
is not deleted). Later on, when the checkpoint is created again, it
will not
succeed because the CPD detects that the checkpoint IMM object existing.
Fix:
---- The solution is to delete the existing checkpoint IMM object and
re-
create a new object during creating checkpoint process.
Complete diffstat:
------------------
osaf/services/saf/cpsv/cpd/cpd_db.c | 15 +++++++++++++++
osaf/services/saf/cpsv/cpd/cpd_evt.c | 6 +++---
osaf/services/saf/cpsv/cpd/cpd_proc.c | 9 +++++++--
3 files changed, 25 insertions(+), 5 deletions(-)
Testing Commands:
-----------------
Follow test steps described in the ticket
Testing, Expected Results:
--------------------------
Opening checkpoint should not fail permanently.
Conditions of Submission:
-------------------------
-
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
