Summary: amf: support 75 node deployments [#1815] 
Review request for Trac Ticket(s): 1815 
Peer Reviewer(s): AMF devs 
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): all
Development branch: default 

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y 
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 5599d81c5a6fd779b9bca741ae51ea7628064d14
Author: Gary Lee <[email protected]>
Date:   Mon, 09 May 2016 16:57:16 +1000

        amf: support 75 node deployments [#1815]

        On a 75 node deployment, avd_imm_config_get() can take up to 3 minutes 
to
        complete. The default heartbeat period of 60s between amfnd and amfd 
does
        not allow enough time for avd_imm_config_get() to finish. The same 
thread is
        handling both heartbeat and reading of IMM.

        Furthermore, it has been observed that CLM callbacks to amfd can become
        'lost' in a large cluster. It seems to be occurring in MDS, when the
        callbacks are sent around the same time as amfd is calling
        avd_imm_config_get(). A workaround is to call avd_clm_track_start() 
after
        avd_imm_config_get() is completed. Further investigations are required. 
It
        seems avd_imm_config_get() generates a large amount of traffic through 
MDS.


Complete diffstat:
------------------
 osaf/libs/common/amf/include/amf_defs.h |   2 +-
 osaf/services/saf/amf/amfd/role.cc      |  10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)


Testing Commands:
-----------------
Start a cluster with 75+ nodes.

Testing, Expected Results:
--------------------------
Cluster starts and amf-status is OK, and no heartbeat timeout occurs

Conditions of Submission:
-------------------------
 <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y 
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to