Hi Hung,

Since isOmDone is used in implementer_thread(), it would be good to set 
isOmDone to 0 before the thread is created (isReady and isOiDone are also set 
to 0).
By default isOmDone is set to zero, and this will be only a precaution for 
adding more tests and that we don't have interference between tests.

Reviewed the patch.
Ack from me.

Thanks,
Zoran

-----Original Message-----
From: Hung Nguyen [mailto:[email protected]] 
Sent: Friday, May 06, 2016 8:10 AM
To: Zoran Milinkovic <[email protected]>; 
[email protected]
Cc: [email protected]
Subject: [PATCH 1 of 1] imm: Do not dispatch after finalizing oi handle in 
OmThreadInterference testcase [#1804]

 tests/immsv/management/test_saImmOmThreadInterference.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Do not dispatch after finalizing oi handle in OmThreadInterference testcase.

diff --git a/tests/immsv/management/test_saImmOmThreadInterference.c 
b/tests/immsv/management/test_saImmOmThreadInterference.c
--- a/tests/immsv/management/test_saImmOmThreadInterference.c
+++ b/tests/immsv/management/test_saImmOmThreadInterference.c
@@ -57,9 +57,9 @@ static void *implementer_thread(void *ar
 
        isReady = 1;
 
-       while(1) {
+       while(!isOmDone) {
                ret = poll(fd, 1, 1000);
-               if(ret == 1)
+               if(ret == 1 && !isOmDone)
                        if((err = saImmOiDispatch(immOiHandle, 
SA_DISPATCH_ONE)) != SA_AIS_OK)
                                break;
        }

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to