Ack code review only. Thanks, Praveen
On 01-Jun-16 6:02 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfnd/chc.cc | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > > If the component is not in instantiated state, then hc expiry > should be ignored. > > diff --git a/osaf/services/saf/amf/amfnd/chc.cc > b/osaf/services/saf/amf/amfnd/chc.cc > --- a/osaf/services/saf/amf/amfnd/chc.cc > +++ b/osaf/services/saf/amf/amfnd/chc.cc > @@ -926,6 +926,16 @@ uint32_t avnd_comp_hc_rec_tmr_exp(AVND_C > > TRACE_ENTER2("%s - %s, sts: %u", comp->name.value, rec->key.key, > rec->status); > > + /* There is a chance that the term command has been issued to comp and > + the timer has expired and it is in mail box. > + So, if the component is not in healthy state, then don't start HC. */ > + > + if (!m_AVND_COMP_PRES_STATE_IS_INSTANTIATED(comp)) { > + TRACE_1("'%s' not instantiated, not starting HC", > comp->name.value); > + rec->status = AVND_COMP_HC_STATUS_STABLE; > + return rc; > + } > + > if (m_AVND_COMP_HC_REC_IS_AMF_INITIATED(rec)) { > if (rec->status == AVND_COMP_HC_STATUS_STABLE) > if (comp->is_hc_cmd_configured && > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel